Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds testimonials #463

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Adds testimonials #463

merged 1 commit into from
Dec 6, 2024

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Dec 6, 2024

Since we need them.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Important

Adds a testimonials section to the documentation and a script to generate testimonial HTML.

  • Documentation:
    • Added a "Testimonials" section in README.md and docs/main.rst with user feedback on Burr.
    • Included testimonials.css in docs/conf.py for styling the testimonials.
  • Scripts:
    • New script make_testimonials.py to generate HTML for testimonials using a predefined template and a list of testimonials.

This description was created by Ellipsis for 3878bba. It will automatically update as commits are pushed.

Since we need them.
Copy link

github-actions bot commented Dec 6, 2024

A preview of is uploaded and can be seen here:

https://burr.dagworks.io/pull/463

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/463/

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3878bba in 1 minute and 25 seconds

More details
  • Looked at 235 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. README.md:154
  • Draft comment:
    The link to the CSS file is incorrect. It should point to a valid URL or a local path within the repository. Please update the link to ensure the CSS is applied correctly.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. docs/main.rst:35
  • Draft comment:
    The link to the CSS file is incorrect. It should point to a valid URL or a local path within the repository. Please update the link to ensure the CSS is applied correctly.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_DRhlFoE772PFYjtq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@skrawcz skrawcz merged commit 0c042ad into main Dec 6, 2024
11 checks passed
@skrawcz skrawcz deleted the add_testimonials branch December 6, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant