Skip to content

Commit

Permalink
PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
skrawcz committed Aug 19, 2024
1 parent e88a2e1 commit 3ba41ac
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def best_model_per_series(cross_validation_evaluation: pd.DataFrame) -> pd.Serie
def inference_predictions(
forecaster: StatsForecast,
inference_forecast_steps: int = 12,
inference_confidence_percentile: list[float] = [90.0], # noqa
inference_confidence_percentile: list[float] = [90.0], # noqa: B006
) -> pd.DataFrame:
"""Infer values using the training harness. Fitted models aren't stored
Expand Down
2 changes: 1 addition & 1 deletion contrib/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
try:
with open("README.md") as readme_file:
readme = readme_file.read()
except Exception:
except FileNotFoundError:
warnings.warn("README.md not found") # noqa
readme = None

Expand Down
1 change: 0 additions & 1 deletion examples/LLM_Workflows/image_telephone/streamlit.py
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,6 @@ def explore_display():
image_urls_to_display = image_urls[0 : len(projection)]
if len(image_urls_to_display) != len(projection):
image_url_length = len(image_urls_to_display)
# for i in range(len(projection) - len(image_urls_to_display)):
image_urls_to_display.append(image_urls[image_url_length - 1])
embedding_path_plot(projection, image_urls_to_display, selected_entry, prompt_path)
# highlight_point(projection, selected_entry)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def pdf_text(pdf_path: pd.Series) -> pd.Series:
:return: Series of strings of the PDFs' contents
"""
_pdf_text = []
for _, file_path in pdf_path.items():
for _i, file_path in pdf_path.items():
# creating a pdf reader object
reader = PdfReader(file_path)
text = ""
Expand Down
5 changes: 2 additions & 3 deletions examples/due_date_probabilities/probability_estimation.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,9 @@ def raw_probabilities(raw_data: str) -> pd.DataFrame:

def resampled(raw_probabilities: pd.DataFrame) -> List[int]:
sample_data = []
for _, row in raw_probabilities.iterrows():
for _idx, row in raw_probabilities.iterrows():
count = row.probability * 1000
for _i in range(int(count)):
sample_data.append(row.days)
sample_data.extend([row.days] * int(count))
return sample_data


Expand Down
2 changes: 1 addition & 1 deletion hamilton/execution/state.py
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def realize_parameterized_group(
for dependency in new_task.base_dependencies:
new_dependencies[dependency] = []
if dependency in task_names_in_group:
for _, name_map in name_maps.items():
for _group_name, name_map in name_maps.items():
new_dependencies[dependency].append(name_map[dependency])
else:
new_dependencies[dependency].append(dependency)
Expand Down

0 comments on commit 3ba41ac

Please sign in to comment.