Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links from node -> dependenciy #1051

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Fix links from node -> dependenciy #1051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cadba05
Fixes links in hamilton from node -> downstream node
elijahbenizzy Jul 20, 2024
428ce30
Bumps hamilton version from 0.0.13 to 0.0.14
elijahbenizzy Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/backend/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def load_requirements():

setup(
name="sf-hamilton-ui", # there's already a hamilton in pypi
version="0.0.13",
version="0.0.14",
description="Hamilton, the micro-framework for creating dataframes.",
long_description="""Hamilton tracking server, see [the docs for more](https://github.com/dagworks-inc/hamilton/tree/main/ui/)""",
long_description_content_type="text/markdown",
Expand Down
14 changes: 6 additions & 8 deletions ui/frontend/src/components/dashboard/Runs/Task/Task.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ErrorView } from "./ErrorView";
import { CodeSummaryView } from "./CodeView";
import { BiChevronLeft } from "react-icons/bi";
import { Fragment } from "react";
import { Menu, Transition } from "@headlessui/react";
import { Menu, MenuItem, MenuItems, Transition } from "@headlessui/react";
import { ChevronDownIcon } from "@heroicons/react/20/solid";
import ReactSelect from "react-select";
import {
Expand All @@ -16,9 +16,7 @@ import {
getNodeOutputType,
} from "../../../../state/api/friendlyApi";
import { NodeMetadataPythonType1 } from "../../../../state/api/backendApiRaw";
import {
MultiResultSummaryView,
} from "./result-summaries/DataObservability";
import { MultiResultSummaryView } from "./result-summaries/DataObservability";
import { RunLink } from "../../../common/CommonLinks";
import { extractCodeContents } from "../../../../utils/codeExtraction";

Expand Down Expand Up @@ -208,7 +206,7 @@ export const NodeLinkMenu = (props: {
leaveFrom="transform opacity-100 scale-100"
leaveTo="transform opacity-0 scale-95"
>
<Menu.Items
<MenuItems
className="absolute right-0 z-10 mt-2
origin-top-right rounded-md bg-white shadow-lg ring-1 ring-black ring-opacity-5 focus:outline-none w-max"
>
Expand All @@ -222,7 +220,7 @@ export const NodeLinkMenu = (props: {
const Icon = getPythonTypeIcon(pythonType);
const multipleRuns = nodeLink.runIds.length > 1;
return (
<Menu.Item key={i} disabled>
<MenuItem key={i} disabled={disabled}>
{() => (
<Link
to={
Expand Down Expand Up @@ -263,11 +261,11 @@ export const NodeLinkMenu = (props: {
</div>
</Link>
)}
</Menu.Item>
</MenuItem>
);
})}
</div>
</Menu.Items>
</MenuItems>
</Transition>
</Menu>
);
Expand Down
Loading