We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In #102 @srhb introduces a Nix flake check that ensures the codebase passes clippy lints.
Following up on that (because the PR is already huge and shouldn't be expanded, to keep it reviewable), I think it would be a good idea to:
nix flake check
nix build ./#checks.<system>.<check>
.unwrap
rustfmt
All of these would drastically increase the quality of the codebase, and aren't overly hard to get done.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
In #102 @srhb introduces a Nix flake check that ensures the codebase passes clippy lints.
Following up on that (because the PR is already huge and shouldn't be expanded, to keep it reviewable), I think it would be a good idea to:
nix flake checkinto severalnix build ./#checks.<system>.<check>CI jobs, which makes it more obvious what fails, and may help with caching in the future. #107.unwrapthroughout the codebase, since it is very bad practice and creates undecipherable error messages. #108rustfmtwith the flake, and making it a flake check, that also gets its own build job in CI. #109All of these would drastically increase the quality of the codebase, and aren't overly hard to get done.
The text was updated successfully, but these errors were encountered: