Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't redo certain commands after undoing a "multiply tempo" #78

Open
rozlynd opened this issue Oct 10, 2024 · 1 comment
Open

Can't redo certain commands after undoing a "multiply tempo" #78

rozlynd opened this issue Oct 10, 2024 · 1 comment
Assignees
Labels

Comments

@rozlynd
Copy link
Collaborator

rozlynd commented Oct 10, 2024

Starting from some sequence:

  1. Multiply tempo (by 2 for example);
  2. Add a note on one of the empty lines just created;
  3. Undo twice to remove the note and restore the original tempo;
  4. Redo the Multiply Tempo;
  5. Redo again: the note is not re-added like it should.

This is just an example. It happens because the Command Manager stores information that may become invalid as a result of some undos. In this case, the line in which a note should be re-inserted has been removed from the sequence.

@DC37 DC37 added the bug label Dec 9, 2024
@rozlynd rozlynd self-assigned this Dec 9, 2024
@rozlynd
Copy link
Collaborator Author

rozlynd commented Dec 9, 2024

What I really want is to make some structures immutable, so all the editing has to go through some specific class that has access to the sequence's data (maybe StaffSequence itself). This problem will have to be resolved in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants