Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate .js files by resposibility #37

Open
ManiAkasapu opened this issue Nov 8, 2020 · 1 comment
Open

Seperate .js files by resposibility #37

ManiAkasapu opened this issue Nov 8, 2020 · 1 comment
Labels
dev-task Improvement that doesn't fit under the enhancements category

Comments

@ManiAkasapu
Copy link
Member

Currently all functions/functionality scattered across js files. This is the task to bring all of them together and put them in meaningful way. This includes moving function to different .js file, Creating & renaming .js file if needed etc.
Ultimately, We should be able to tell which .js file is responsible for a particular functionality. For example,

uicontrol.js  // deal with what /when the UI should be changed
storageControl.js // deal with storage related funtions
locomotives.js  // deal with locomotives data logic
functionamapping.js // deal with maps

Not only files but also functions inside each file should be in meaningful order to increase find-ability.

@matt-vdv matt-vdv added this to the 1.3.0 milestone Nov 8, 2020
@matt-vdv
Copy link
Member

matt-vdv commented Nov 8, 2020

@ManiAkasapu Very good idea as at the moment exwebthrottle.js contains most of the code. Added to version 1.3.0 milestone

@matt-vdv matt-vdv added dev-task Improvement that doesn't fit under the enhancements category Next-Release feature to be included in the next release labels Nov 8, 2020
@matt-vdv matt-vdv removed the Next-Release feature to be included in the next release label Nov 21, 2020
@matt-vdv matt-vdv removed this from the 1.3.0 milestone Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-task Improvement that doesn't fit under the enhancements category
Projects
None yet
Development

No branches or pull requests

2 participants