Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New withdrawal reasons table #10201

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Dec 20, 2024

Context

This is the first of three PRs related to the new withdrawal reasons journey and data model. This first one is just the migration. The next two will be (1) Feature flag, models, yml files (2) UI journey

Changes proposed in this pull request

No UI changes, just the migration.

Guidance to review

Are we happy with the table name 'withdrawal_reasons?'

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@elceebee
Copy link
Contributor Author

@elceebee elceebee marked this pull request as ready for review December 20, 2024 15:52
@elceebee elceebee requested a review from a team December 20, 2024 15:53
Copy link
Contributor

Database-level enum changes detected

Please include a data migration for these attributes and values:

0a1
> <enum> WithdrawalReason.status: ["draft", "published"]

@elceebee elceebee force-pushed the 426-withdrawal-reasons-migrations branch from 18b20fa to e3886df Compare December 20, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant