From f891877a7aaa872b4e272125fffe469a5ad639ba Mon Sep 17 00:00:00 2001 From: Colin Saliceti Date: Thu, 8 Dec 2022 12:02:02 +0000 Subject: [PATCH 1/2] Remove HTTP auth from pagespeed The pagespeed endpoint doesn't require authentication so we don't need to send the credentials --- .github/workflows/pagespeed.yml | 20 +++----------------- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/.github/workflows/pagespeed.yml b/.github/workflows/pagespeed.yml index bd420fc9a7..2930298a71 100644 --- a/.github/workflows/pagespeed.yml +++ b/.github/workflows/pagespeed.yml @@ -8,24 +8,10 @@ jobs: pagespeed: runs-on: ubuntu-latest steps: - - - uses: Azure/login@v1 - with: - creds: ${{ secrets.AZURE_CREDENTIALS }} - - - uses: DfE-Digital/keyvault-yaml-secret@v1 - id: keyvault-yaml-secret - with: - keyvault: ${{ secrets.KEY_VAULT}} - secret: INFRA-KEYS - key: HTTP-USERNAME, HTTP-PASSWORD - - - name: Run Page Speed Tas + - name: Run Page Speed uses: fjogeleit/http-request-action@86014825e97036cd3e0903bbc72b3c5fff7474c4 with: - url: 'https://get-into-teaching-app-pagespeed.london.cloudapps.digital/pagespeed/run' - method: 'POST' - username: ${{ steps.keyvault-yaml-secret.outputs.HTTP-USERNAME }} - password: ${{ steps.keyvault-yaml-secret.outputs.HTTP-PASSWORD }} + url: https://get-into-teaching-app-pagespeed.london.cloudapps.digital/pagespeed/run + method: POST timeout: 3600000 # 1hr in ms preventFailureOnNoResponse: true From 3363785aecb25d8a1f9afb266f750fa5343adeff Mon Sep 17 00:00:00 2001 From: Colin Saliceti Date: Fri, 9 Dec 2022 16:55:22 +0000 Subject: [PATCH 2/2] Revert fjogeleit/http-request-action to known working version The new version times out after 15 min --- .github/workflows/pagespeed.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pagespeed.yml b/.github/workflows/pagespeed.yml index 2930298a71..bc3eb6e913 100644 --- a/.github/workflows/pagespeed.yml +++ b/.github/workflows/pagespeed.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Run Page Speed - uses: fjogeleit/http-request-action@86014825e97036cd3e0903bbc72b3c5fff7474c4 + uses: fjogeleit/http-request-action@fd5cf60c69049efb1397207cc8b442709a869685 with: url: https://get-into-teaching-app-pagespeed.london.cloudapps.digital/pagespeed/run method: POST