From 90130aa5955840c8923ea592dee9e7ab954b4c2c Mon Sep 17 00:00:00 2001 From: Ross Oliver Date: Mon, 13 Feb 2023 14:17:58 +0000 Subject: [PATCH] Update GiT API client Update the API client to the latest version, which includes a breaking change that splits out `LookupItem` into new `Country` and `TeachingSubject` models. --- Gemfile.lock | 8 ++++---- spec/models/events/steps/personalised_updates_spec.rb | 2 +- spec/models/mailing_list/steps/subject_spec.rb | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index b3fb7fe821..e1fc1bce06 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -9,11 +9,11 @@ GIT GIT remote: https://github.com/DFE-Digital/get-into-teaching-api-ruby-client.git - revision: faced708d161b73a567d7eea766c6afb5795834c + revision: 7f776f597109304f275db26852051b19070e568d specs: - get_into_teaching_api_client (2.3.0) + get_into_teaching_api_client (3.0.0) faraday (~> 1.0, >= 1.0.1) - get_into_teaching_api_client_faraday (2.3.0) + get_into_teaching_api_client_faraday (3.0.0) activesupport faraday faraday-encoding @@ -188,7 +188,7 @@ GEM factory_bot_rails (6.2.0) factory_bot (~> 6.2.0) railties (>= 5.0.0) - faraday (1.10.2) + faraday (1.10.3) faraday-em_http (~> 1.0) faraday-em_synchrony (~> 1.0) faraday-excon (~> 1.1) diff --git a/spec/models/events/steps/personalised_updates_spec.rb b/spec/models/events/steps/personalised_updates_spec.rb index 6ff975bfe9..68fff1da69 100644 --- a/spec/models/events/steps/personalised_updates_spec.rb +++ b/spec/models/events/steps/personalised_updates_spec.rb @@ -104,7 +104,7 @@ let(:teaching_subject_types) do subjects = TeachingSubject::ALL.merge(TeachingSubject::IGNORED) - subjects.map { |k, v| GetIntoTeachingApiClient::LookupItem.new({ id: v, value: k }) } + subjects.map { |k, v| GetIntoTeachingApiClient::TeachingSubject.new({ id: v, value: k }) } end before do diff --git a/spec/models/mailing_list/steps/subject_spec.rb b/spec/models/mailing_list/steps/subject_spec.rb index b93992e21b..f77f7b7e53 100644 --- a/spec/models/mailing_list/steps/subject_spec.rb +++ b/spec/models/mailing_list/steps/subject_spec.rb @@ -8,7 +8,7 @@ end let(:teaching_subject_types) do - TeachingSubject::ALL.map { |k, v| GetIntoTeachingApiClient::LookupItem.new({ id: v, value: k }) } + TeachingSubject::ALL.map { |k, v| GetIntoTeachingApiClient::TeachingSubject.new({ id: v, value: k }) } end it_behaves_like "a with wizard step" @@ -30,7 +30,7 @@ let(:teaching_subject_types) do subjects = TeachingSubject::ALL.merge(TeachingSubject::IGNORED) - subjects.map { |k, v| GetIntoTeachingApiClient::LookupItem.new({ id: v, value: k }) } + subjects.map { |k, v| GetIntoTeachingApiClient::TeachingSubject.new({ id: v, value: k }) } end it { is_expected.to eq(TeachingSubject.all_uuids) }