From 98432db258b0d3d1ef53002ed636eae622438e23 Mon Sep 17 00:00:00 2001 From: emmaachesongray <168454683+emmaachesongray@users.noreply.github.com> Date: Tue, 10 Dec 2024 14:42:54 +0000 Subject: [PATCH 1/5] Update mailing list content --- app/views/mailing_list/steps/_name.html.erb | 19 +++---------------- spec/features/mailing_list_wizard_spec.rb | 2 +- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/app/views/mailing_list/steps/_name.html.erb b/app/views/mailing_list/steps/_name.html.erb index 46dd8f430a..cf51c84bd8 100644 --- a/app/views/mailing_list/steps/_name.html.erb +++ b/app/views/mailing_list/steps/_name.html.erb @@ -1,20 +1,9 @@ -
-If you're interested in training to teach in primary, secondary and special schools in England, get everything you need to know to start a career in teaching. +Discover everything you need to know to start a teaching career in England, sent straight to your inbox. Personalised to you, we'll send you the latest information as well as advice and support.
--Find out how to get: -
- -Your details are protected under the terms of our <%= link_to("privacy notice (opens in new tab)", privacy_policy_path(id: f.object.latest_privacy_policy.id), { target: :blank }) %>.
- -Our privacy notice explains how we use your personal data. It's important you read this before signing up to receive emails.
+Your details are protected under the terms of our <%= link_to("privacy notice (opens in new tab)", privacy_policy_path(id: f.object.latest_privacy_policy.id), { target: :blank }) %>. Our privacy notice explains how we use your personal data. It's important you read this before signing up to receive emails.
diff --git a/spec/features/mailing_list_wizard_spec.rb b/spec/features/mailing_list_wizard_spec.rb index 088be81796..ec76de8716 100644 --- a/spec/features/mailing_list_wizard_spec.rb +++ b/spec/features/mailing_list_wizard_spec.rb @@ -14,7 +14,7 @@ expect(page).to have_title(mailing_list_page_title) - expect(page).to have_text "Get personalised guidance on teacher training in your inbox" + expect(page).to have_text "Free personalised teacher training guidance" fill_in_name_step click_on "Next step" From 0ee1ee4bfd98a2103dbfa9f19963f70045363817 Mon Sep 17 00:00:00 2001 From: emmaachesongray <168454683+emmaachesongray@users.noreply.github.com> Date: Tue, 10 Dec 2024 14:55:58 +0000 Subject: [PATCH 2/5] update spec test --- spec/features/mailing_list_wizard_spec.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/spec/features/mailing_list_wizard_spec.rb b/spec/features/mailing_list_wizard_spec.rb index ec76de8716..1f1e27de63 100644 --- a/spec/features/mailing_list_wizard_spec.rb +++ b/spec/features/mailing_list_wizard_spec.rb @@ -54,7 +54,7 @@ channel_id = channels.first.id visit mailing_list_steps_path({ id: :name, channel: channel_id, sub_channel: sub_channel_id }) - expect(page).to have_text "Get personalised guidance on teacher training in your inbox" + expect(page).to have_text "Free personalised teacher training guidance" # Error to ensure channel/sub-channel persists over page reload. click_on "Next step" expect(page).to have_text("Enter your full email address") @@ -96,7 +96,7 @@ channel_id = channels.first.id visit mailing_list_steps_path({ id: :name, channel: channel_id, sub_channel: sub_channel_id }) - expect(page).to have_text("Get personalised guidance on teacher training in your inbox") + expect(page).to have_text("Free personalised teacher training guidance") fill_in_name_step click_on "Next step" @@ -135,7 +135,7 @@ visit mailing_list_steps_path({ id: :name, channel: "invalid", sub_channel: sub_channel_id }) - expect(page).to have_text "Get personalised guidance on teacher training in your inbox" + expect(page).to have_text "GFree personalised teacher training guidance" fill_in_name_step click_on "Next step" @@ -179,7 +179,7 @@ visit mailing_list_steps_path - expect(page).to have_text "Get personalised guidance on teacher training in your inbox" + expect(page).to have_text "Free personalised teacher training guidance" fill_in_name_step(first_name: first_name) click_on "Next step" @@ -243,7 +243,7 @@ visit mailing_list_steps_path - expect(page).to have_text "Get personalised guidance on teacher training in your inbox" + expect(page).to have_text "Free personalised teacher training guidance" fill_in_name_step click_on "Next step" From 3adae5afd9bb557e8e34c26d4fc70ec3ae0b90d5 Mon Sep 17 00:00:00 2001 From: emmaachesongray <168454683+emmaachesongray@users.noreply.github.com> Date: Tue, 10 Dec 2024 15:11:41 +0000 Subject: [PATCH 3/5] spec --- docs/sign-up-journeys.md | 2 +- spec/features/mailing_list_wizard_spec.rb | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/sign-up-journeys.md b/docs/sign-up-journeys.md index 3118ea7a8a..79ebf7c0bd 100644 --- a/docs/sign-up-journeys.md +++ b/docs/sign-up-journeys.md @@ -6,7 +6,7 @@ There are multiple different sign up journeys available on the Get into Teaching ```mermaid graph TD; - name[Get personalised guidance on teacher training in your inbox] -- Doesn't exist in CRM --> returning_teacher[Are you already qualified to teach?] + name[Free personalised teacher training guidanceer training in your inbox] -- Doesn't exist in CRM --> returning_teacher[Are you already qualified to teach?] name -- Exists in CRM --> authenticate[You're already registered with us] returning_teacher -- Yes --> already_qualified[We're sorry, but our emails are for people who are not already qualified to teach] diff --git a/spec/features/mailing_list_wizard_spec.rb b/spec/features/mailing_list_wizard_spec.rb index 1f1e27de63..016c090002 100644 --- a/spec/features/mailing_list_wizard_spec.rb +++ b/spec/features/mailing_list_wizard_spec.rb @@ -135,7 +135,7 @@ visit mailing_list_steps_path({ id: :name, channel: "invalid", sub_channel: sub_channel_id }) - expect(page).to have_text "GFree personalised teacher training guidance" + expect(page).to have_text "Free personalised teacher training guidancee" fill_in_name_step click_on "Next step" @@ -219,7 +219,7 @@ visit mailing_list_steps_path - expect(page).to have_text "Get personalised guidance on teacher training in your inbox" + expect(page).to have_text "Free personalised teacher training guidance" fill_in_name_step click_on "Next step" @@ -274,7 +274,7 @@ visit mailing_list_steps_path - expect(page).to have_text "Get personalised guidance on teacher training in your inbox" + expect(page).to have_text "Free personalised teacher training guidance" fill_in_name_step click_on "Next step" @@ -298,7 +298,7 @@ visit mailing_list_steps_path - expect(page).to have_text "Get personalised guidance on teacher training in your inbox" + expect(page).to have_text "Free personalised teacher training guidance" fill_in_name_step click_on "Next step" @@ -378,7 +378,7 @@ visit mailing_list_steps_path - expect(page).to have_text "Get personalised guidance on teacher training in your inbox" + expect(page).to have_text "Free personalised teacher training guidance" fill_in_name_step click_on "Next step" @@ -395,7 +395,7 @@ allow_any_instance_of(GetIntoTeachingApiClient::CandidatesApi).to \ receive(:create_candidate_access_token).and_raise(GetIntoTeachingApiClient::ApiError) - expect(page).to have_text "Get personalised guidance on teacher training in your inbox" + expect(page).to have_text "Free personalised teacher training guidance" fill_in_name_step(email: "test2@user.com") click_on "Next step" From caaa387193cf0527f1d015b5c7bc0f95bfcbe17d Mon Sep 17 00:00:00 2001 From: emmaachesongray <168454683+emmaachesongray@users.noreply.github.com> Date: Tue, 10 Dec 2024 15:33:41 +0000 Subject: [PATCH 4/5] Apply suggestions from code review --- docs/sign-up-journeys.md | 2 +- spec/features/mailing_list_wizard_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/sign-up-journeys.md b/docs/sign-up-journeys.md index 79ebf7c0bd..5ac22181e4 100644 --- a/docs/sign-up-journeys.md +++ b/docs/sign-up-journeys.md @@ -6,7 +6,7 @@ There are multiple different sign up journeys available on the Get into Teaching ```mermaid graph TD; - name[Free personalised teacher training guidanceer training in your inbox] -- Doesn't exist in CRM --> returning_teacher[Are you already qualified to teach?] + name[Free personalised teacher training guidance] -- Doesn't exist in CRM --> returning_teacher[Are you already qualified to teach?] name -- Exists in CRM --> authenticate[You're already registered with us] returning_teacher -- Yes --> already_qualified[We're sorry, but our emails are for people who are not already qualified to teach] diff --git a/spec/features/mailing_list_wizard_spec.rb b/spec/features/mailing_list_wizard_spec.rb index 016c090002..e3a421ac91 100644 --- a/spec/features/mailing_list_wizard_spec.rb +++ b/spec/features/mailing_list_wizard_spec.rb @@ -135,7 +135,7 @@ visit mailing_list_steps_path({ id: :name, channel: "invalid", sub_channel: sub_channel_id }) - expect(page).to have_text "Free personalised teacher training guidancee" + expect(page).to have_text "Free personalised teacher training guidance" fill_in_name_step click_on "Next step" From 67f839b7c4dda74be888538940d3c23193136448 Mon Sep 17 00:00:00 2001 From: emmaachesongray <168454683+emmaachesongray@users.noreply.github.com> Date: Wed, 11 Dec 2024 09:49:00 +0000 Subject: [PATCH 5/5] Update app/views/mailing_list/steps/_name.html.erb Co-authored-by: Gemma Dallman <87642394+gemmadallmandfe@users.noreply.github.com> --- app/views/mailing_list/steps/_name.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/mailing_list/steps/_name.html.erb b/app/views/mailing_list/steps/_name.html.erb index cf51c84bd8..60806f31c9 100644 --- a/app/views/mailing_list/steps/_name.html.erb +++ b/app/views/mailing_list/steps/_name.html.erb @@ -11,4 +11,4 @@ Discover everything you need to know to start a teaching career in England, sent <%= f.hidden_field :sub_channel_id, value: params[:sub_channel] || f.object.sub_channel_id %> <%= f.hidden_field :accepted_policy_id, value: f.object.latest_privacy_policy.id %> -Your details are protected under the terms of our <%= link_to("privacy notice (opens in new tab)", privacy_policy_path(id: f.object.latest_privacy_policy.id), { target: :blank }) %>. Our privacy notice explains how we use your personal data. It's important you read this before signing up to receive emails.
+Your details are protected under the terms of our <%= link_to("privacy notice (opens in new tab)", privacy_policy_path(id: f.object.latest_privacy_policy.id), { target: :blank }) %>. This explains how we use your personal data. It's important you read this before signing up to receive emails.