Releases: DFE-Digital/get-into-teaching-app
Release 3142
The version of openssl in the alpine docker image has vulnerabilities, see:
https://security.snyk.io/vuln/SNYK-ALPINE316-OPENSSL-3314624
https://security.snyk.io/vuln/SNYK-ALPINE316-OPENSSL-3314641
https://security.snyk.io/vuln/SNYK-ALPINE316-OPENSSL-3314643
Release 3141
Trello card
Context
Request received via GIT support team (and approved by Accreditation team) to add i2i Teaching Partnership to Assessment only page
Release 3139
These have started failing as the test can't find the new radio button on the returning teacher exclusion step; I can't immediately see why and we need to ship this change so I'll revisit this.
Release 3138
The mailing list now has an additional step we need to account for in the integration tests.
Release 3137
Trello card
Context
We need to improve the copy on the mailing list start page to make it clear that it provides guidance for teacher training.
Changes proposed in this pull request
Guidance to review
Release 3129
Trello card
Context
The mailing list only provides guidance around teacher training, not for teachers already qualified. We need to make this clearer to the users to stop domestic and internationally qualified teachers signing up.
Changes proposed in this pull request
Guidance to review
Release 3136
Trello card
Context
Update with the latest CSV.
Changes proposed in this pull request
- Update internship providers
Guidance to review
Release 3133
Trello card
Trello-4245https://trello.com/c/3viAxYsH/4245-remove-webpacker-from-git-and-get-an-adviser-apps
Context
Webpacker is no longer maintained and several of the dependencies now have vulnerabilities that, whilst patched, haven't made it upstream into the Webpacker gem and likely won't.
Changes proposed in this pull request
- Migrate to Shakapacker
Migrate to Shackapacker; whilst there are other build tools that we can use for Rails 7 this is the path of least resistance and brings the application
inline/consistent with other GiT apps.
Notable changes;
- Shackapacker only allows a single
javascript_pack_tag
(which supports multiple JS files as arguments). This required shuffling the logic around the head tag so we can still conditionally include packs on certain pages. - Binstubs updated and are now
webpacker*
rather thanwebpack*
. - Paths to static files had to be updated to match the new manifest.json.
- Remove browserlist.rc and bring it into package.json to be consistent with other GiT apps.
It may be worth switching to esbuild
in the future but for now I've retained babel
for transpiling.
Guidance to review
I had to reshuffle how we conditionally include JS so its worth testing these packs specifically; govuk frontend, internal events portal, optimize, GTM. We should also test the next gen images are still being generated correctly once in production.
Release 3124
Trello card
Context
Update the API client to the latest version, which includes a breaking change that splits out LookupItem
into new Country
and TeachingSubject
models.
Changes proposed in this pull request
- Update GiT API client
Guidance to review
Release 3127
Trello card
Context
Enable Google Optimize on the web pages used as part of the salaries and benefits A/B test.
Changes proposed in this pull request
- Enable Google Optimize for Salaries & Benefits A/B test