Releases: DFE-Digital/schools-experience
v185118-stable: Merge pull request #1834 from DFE-Digital/missing-contact-name
Alias firstname/lastname on MissingContact
Release 1833
Trello card
Context
The webpack-cli package is not really needed.
Changes proposed in this pull request
Remove it from the dependencies
Release 1822
Trello card
Context
We are removing the legacy, direct CRM integration code from the app now that we are happy that the API integration is working as expected. This will involve a number of PRs to incrementally remove the old code.
Changes proposed in this pull request
Remove the remaining, now unused legacy code that implements the direct integration with the CRM. A couple of error classes/constants needed shuffling about to retain references but its pretty much just wiping out code.
Guidance to review
I would have liked to have done this in smaller changes but the way its all tied together means it needs to be done in a bit of a big bang to get everything green.
Release 1821
Trello card
Context
We are removing the legacy, direct CRM integration code from the app now that we are happy that the API integration is working as expected. This will involve a number of PRs to incrementally remove the old code.
Changes proposed in this pull request
Remove legacy code from the two remaining core classes (ContactFetcher and GitisAuthenticate concern). Many specs end up calling code in these classes so it meant I had to go and update a bunch of failing tests to use the correct candidate model type and mocking of the API.
Guidance to review
I would have liked to have done this in smaller changes but the way its all tied together means it needs to be done in a bit of a big bang to get everything green.
Release 1819
Trello card
Context
We are removing the legacy, direct CRM integration code from the app now that we are happy that the API integration is working as expected. This will involve a number of PRs to incrementally remove the old code.
Changes proposed in this pull request
Remove legacy code from various controllers, models and jobs.
Guidance to review
There are still a few core models which use the feature flags; I'm going to address these in a separate PR as they break a bunch of outer controller/request/feature specs due to needing new mocking in place.
Half a dozen of the selenium/JS cucumber specs are failing in CI; I have no idea why as they pass locally. So I can crack on I've disabled them for now (a number of them have coverage in Capybara anyway). I'll create a ticket to come back to them later.
v184893-stable: Merge pull request #1822 from DFE-Digital/remove-unused-code
Remove remaining, unused direct CRM integration code
v184867-stable
Merge pull request #1819 from DFE-Digital/remove-legacy-crm-integrati…
v184807-stable: Merge pull request #1833 from DFE-Digital/webpacker-cli
Remove the webpack-cli package
Release 1832
Trello card
Context
The postcss-cssnext was deprecated in favour of postcss-preset-env
Changes proposed in this pull request
Replace the postcss-cssnext with postcss-preset-env. Also remove the .postcssrc.yml file.
Guidance to review
Release 1831
Context
Just another application dependencies maintenance
Changes proposed in this pull request
Upgrade the govuk_frontend_toolkit to the latest version