Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binsize argument from gridded_skill #395

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ecomodeller
Copy link
Member

The previous implementation missed parts of the data.

This PR removes this argument.

More explicit control over bins, use the bins argument with a list of bins.

@jsmariegaard
Copy link
Member

I can't really make up my mind about this. Somehow I would like it to be like hist etc where you just have a single argument bins which can be different things. But most times you would actually want to specify just the binsize (which should be the same in x and y direction) e.g. 2 degrees formatted nicely so not -3.3, -1.3, 0.7, ... etc but -4, -2, 0, 2, ... The user can of course do this on their own...

@ecomodeller
Copy link
Member Author

I can't really make up my mind about this. Somehow I would like it to be like hist etc where you just have a single argument bins which can be different things. But most times you would actually want to specify just the binsize (which should be the same in x and y direction) e.g. 2 degrees formatted nicely so not -3.3, -1.3, 0.7, ... etc but -4, -2, 0, 2, ... The user can of course do this on their own...

Sure, but in any case, they want the entire domain to be covered. Not skip some part to the right and the top...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with bin size in spatial_skill minor bug spatial_skill default binning
2 participants