Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching off global | local validation rules (in Territory-based Validation rules) #1989

Open
Tracked by #2136
adammertel opened this issue Mar 20, 2024 · 9 comments · Fixed by #2473
Open
Tracked by #2136
Assignees
Labels
Milestone

Comments

@adammertel
Copy link
Contributor

Owner should be able to switch on/off warnings

@davidzbiral
Copy link
Collaborator

@davidzbiral Write into https://docs.google.com/document/d/1pmsCjNLHAOA58gVrwV64Qfsp-9wO4kZoXbtyjViMuQA/edit what owner should / should not be able to switch off.

@davidzbiral davidzbiral changed the title Global setting for warning rules selection Define which among existing validation rules the owner can switch off in Territory-based Validation rules Mar 23, 2024
@davidzbiral
Copy link
Collaborator

@adammertel , I reviewed this. (Against what I said when we met, the user who has the needed rights should be able to switch off even valency warnings in Statements (mismatch of statement actants with valency frame), because they are disturbing in SumCASTEMO approach.)

Let us do this: Under each T (incl. root T, where, however, only owner can set this; under other Ts anybody who has editing rights to it set this, i.e. any admin, and editors who have this T assigned), in the "Validation rules" section, include the following checboxes (default = all checked in):

  • Validate actant entity type against Action valency frames (this stands the whole section 1 of the gdoc, and allows switching it off, esp. for SumCASTEMO uses)
  • Entity warnings: only in root T, not other Ts, because these are global entity warnings displayed on Detail, not contextual T-based warnings: list one by one the warning messages from the table in the gdoc (they are many, so unfold only upon click, and allow to select/unselect all), each of them as a checkbox, and allow the owner to switch them off by unchecking the box.

Note that in the table, I changed the wording of ca 3 warnings (suggestions highlighted). Please update this in InkV (I changem them in such a way that they serve better the use in this checkbox list.)

I also clarified some texts and the structure for documentation's sake. Have a look at the gdoc and review suggestions.

One important thing that I don't known whether you noted down is:
"Only the user with owner rights can set Validation rules for root T. Validation rules for root T are global, and thus display both on Statements using entities which did not pass validation, and on Detail of those entities (at the same place where we display valency warnings for Actions)." If you haven't noted this down yet, please copy it wherever appropriate.

@davidzbiral
Copy link
Collaborator

davidzbiral commented Mar 23, 2024

@adammertel In relation to this: should we not make the Entity warning descriptions in the table more editor-readable, less technical, and display them also in this list in the app as tooltip? Happy to rewrite, if I have your agreement that it is a good idea to have the more detailed descriptions of the rules there as mouseover tooltip over each of the checkboxes.

@davidzbiral davidzbiral changed the title Define which among existing validation rules the owner can switch off in Territory-based Validation rules Switching off global validation rules (in Territory-based Validation rules) Mar 23, 2024
@davidzbiral
Copy link
Collaborator

Note that my current extension, much more logical I think, even non-owner can switch some things off for his/her Territory. But not global rules, which concern Entities, of course - these only owner can switch off in the settings of root T.

@adammertel
Copy link
Contributor Author

I have moved this issue to 1.4.1

@adammertel adammertel changed the title Switching off global validation rules (in Territory-based Validation rules) Switching off global | local validation rules (in Territory-based Validation rules) Mar 25, 2024
@davidzbiral
Copy link
Collaborator

@adammertel Is anything more needed from me now for this issue?

@adammertel
Copy link
Contributor Author

@davidzbiral no I think this is clear for now. Just moved to 1.4.1 so we can focus on the other things.

@adammertel
Copy link
Contributor Author

@davidzbiral coming back to this - I think it would be a good idea to provide better human-readable non-technical descriptions to the Action valency warnings here

@davidzbiral
Copy link
Collaborator

@ReimaValimaki For me to better understand: what you expect from this? That you will not get Statement-level invalid messages when doing SumCASTEMO, yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants