-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching off global | local validation rules (in Territory-based Validation rules) #1989
Comments
@davidzbiral Write into https://docs.google.com/document/d/1pmsCjNLHAOA58gVrwV64Qfsp-9wO4kZoXbtyjViMuQA/edit what owner should / should not be able to switch off. |
@adammertel , I reviewed this. (Against what I said when we met, the user who has the needed rights should be able to switch off even valency warnings in Statements (mismatch of statement actants with valency frame), because they are disturbing in SumCASTEMO approach.) Let us do this: Under each T (incl. root T, where, however, only owner can set this; under other Ts anybody who has editing rights to it set this, i.e. any admin, and editors who have this T assigned), in the "Validation rules" section, include the following checboxes (default = all checked in):
Note that in the table, I changed the wording of ca 3 warnings (suggestions highlighted). Please update this in InkV (I changem them in such a way that they serve better the use in this checkbox list.) I also clarified some texts and the structure for documentation's sake. Have a look at the gdoc and review suggestions. One important thing that I don't known whether you noted down is: |
@adammertel In relation to this: should we not make the Entity warning descriptions in the table more editor-readable, less technical, and display them also in this list in the app as tooltip? Happy to rewrite, if I have your agreement that it is a good idea to have the more detailed descriptions of the rules there as mouseover tooltip over each of the checkboxes. |
Note that my current extension, much more logical I think, even non-owner can switch some things off for his/her Territory. But not global rules, which concern Entities, of course - these only owner can switch off in the settings of root T. |
I have moved this issue to 1.4.1 |
@adammertel Is anything more needed from me now for this issue? |
@davidzbiral no I think this is clear for now. Just moved to 1.4.1 so we can focus on the other things. |
@davidzbiral coming back to this - I think it would be a good idea to provide better human-readable non-technical descriptions to the Action valency warnings here |
@ReimaValimaki For me to better understand: what you expect from this? That you will not get Statement-level invalid messages when doing SumCASTEMO, yes? |
Owner should be able to switch on/off warnings
The text was updated successfully, but these errors were encountered: