Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation doesn't cover all cases #104

Open
nerodesu017 opened this issue Dec 10, 2024 · 0 comments
Open

Validation doesn't cover all cases #104

nerodesu017 opened this issue Dec 10, 2024 · 0 comments
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@nerodesu017
Copy link
Collaborator

In src/validation/read_constant_expression.rs, the read_constant_instructions doesn't return the created stack so we can't figure out the top value on the stack, making us guess the value at execution (we can't be sure if, for example, it puts a Value::I32 on the stack when at execution time we need it)

@nerodesu017 nerodesu017 added bug Something isn't working invalid This doesn't seem right labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant