Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python wrapper returns SwigPyObject instead of CPACSWalls (Issue #1012) #1035

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

merakulix
Copy link
Contributor

@merakulix merakulix commented Nov 26, 2024

CCPACSWalls couldn't be processed correctly via swig, due to missing include statements in configuration.i.
Adding those includes fixes the issue.

Description

All required includes in configuration.i were added, which are:

  • The header files of the C++ classes that need to be included
  • all header files of classes, that deal with types of "boost-optional" or objects related to "ITiglGeometricComponent" that swig can't process otherwise

The changes fixes #1012 and fixes #986.

How Has This Been Tested?

Running a python script opening the configuration according to Issue #1012 works as expected, also the geometry is exported successful.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.47%. Comparing base (b9c75f1) to head (bc1edbf).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...rc/structural_elements/CCPACSFuselageWallSegment.h 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1035   +/-   ##
=======================================
  Coverage   69.47%   69.47%           
=======================================
  Files         301      301           
  Lines       26889    26889           
=======================================
  Hits        18681    18681           
  Misses       8208     8208           
Flag Coverage Δ
unittests 69.47% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/structural_elements/CCPACSFuselageWallSegment.h 33.33% <33.33%> (ø)

Copy link
Contributor

@joergbrech joergbrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💐

@joergbrech joergbrech merged commit 8c80c8b into master Nov 28, 2024
16 of 17 checks passed
@joergbrech joergbrech deleted the issue1012 branch November 28, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants