From 4043836d5ecf694f5a8eac5be539e4ec86318f73 Mon Sep 17 00:00:00 2001 From: Michael Vasseur <14887731+vmcj@users.noreply.github.com> Date: Sat, 7 Dec 2024 12:37:00 +0100 Subject: [PATCH] Fail integration test on any PHP/Framwork Exception In the past we only did this for warnings in the prod env but those shouldn't happen regardless of if we run those in `dev`, `test` or `prod`. This hopefully protects future tests where we miss this line. --- .github/workflows/integration.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index ce509ac632..765fcef48c 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -141,10 +141,10 @@ jobs: curl $CURLOPTS http://localhost/domjudge/jury/contests/1/freeze/doNow || true curl $CURLOPTS http://localhost/domjudge/jury/contests/1/end/doNow || true curl $CURLOPTS -X POST -d 'finalize_contest[b]=0&finalize_contest[finalizecomment]=gitlab&finalize_contest[finalize]=' http://localhost/domjudge/jury/contests/1/finalize - - name: Verify no errors in prod.log + - name: Verify no errors in symfony {prod,test,dev}.log shell: bash run: | - if cat /opt/domjudge/domserver/webapp/var/log/prod.log | egrep '(CRITICAL|ERROR):'; then + if cat /opt/domjudge/domserver/webapp/var/log/*.log | egrep '(CRITICAL|ERROR):'; then exit 1 fi - name: Download and perform API check