New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sec 21.4.3 (fake news): a few small issues #166

Open

murphyk opened this issue Jul 7, 2023 · 0 comments

murphyk commented Jul 7, 2023

Sec 21.4.3 the table comparing the 3 models performance says "test error" but it should be "test accuracy".

It might be useful to do a little exploratory analysis on the td-idf transformed data before fitting :)

You say the model has "23,804 features" but there are 23812 unique tokens.

Maybe explain how to handle "out of vocabulary" words (like new names of politicians) so model can actually be used on new data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment