Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Fix dlp-cli so that it has better regex for dlp env #988

Open
dwu359 opened this issue Sep 24, 2023 · 3 comments
Open

[BUG]: Fix dlp-cli so that it has better regex for dlp env #988

dwu359 opened this issue Sep 24, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@dwu359
Copy link
Contributor

dwu359 commented Sep 24, 2023

Operating system

Noah's machine

Bug description

The dlp-cli will detect a false positive for a mamba env if the mamba env contains the string "dlp" in it, even if the env is named differently.

Steps to reproduce

Create a mamba env with a name containing "dlp", install backend via dlp-cli

@dwu359 dwu359 added the bug Something isn't working label Sep 24, 2023
@dwu359 dwu359 self-assigned this Sep 24, 2023
@github-actions
Copy link
Contributor

Hello @dwu359! Thank you for submitting the Bug Request Form. We appreciate your contribution. 👋

We will look into it and provide a response as soon as possible.

To work on this bug request, you can follow these branch setup instructions:

  1. Checkout the main branch:
```
 git checkout nextjs
```
  1. Pull the latest changes from the remote main branch:
```
 git pull origin nextjs
```
  1. Create a new branch specific to this bug request using the issue number:
    git checkout -b bug-988

Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

Best regards,
Deep Learning Playground (DLP) Team

@dwu359 dwu359 removed their assignment Sep 24, 2023
@karkir0003
Copy link
Member

@dwu359 this bug isn't just on Noah's machine. It seems to be across diff OS

@dwu359
Copy link
Contributor Author

dwu359 commented Oct 7, 2023

Yep I know, that's just the OS where we discovered the bug, and it definitely isn't an OS dependent bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants