Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about pretrained embeddings #12

Open
ShellingFord221 opened this issue Feb 25, 2019 · 1 comment
Open

about pretrained embeddings #12

ShellingFord221 opened this issue Feb 25, 2019 · 1 comment

Comments

@ShellingFord221
Copy link

Hi,
I have a little question about file 08.CNN-for-Text-Classification.ipynb, [96], line 4: pretrained.append(model[word2index[key]]).
word2index[key] means to find key's index, then you should find its pretrained embedding in GoogleNews-vectors-negative300.bin. But the index in this bin file should be different from the index generated from TREC dataset, i.e. model[key's index] may not be this key's (word's) embedding.
Thanks!

@DSKSD
Copy link
Owner

DSKSD commented Feb 26, 2019

Hi,
Yeah you're right. There are some bugs in this project..
However, I don't have enough time to deal with issues in ad-hoc manner.
So I'm preparing version-up of this repo.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants