Skip to content
This repository has been archived by the owner on Sep 8, 2021. It is now read-only.

Navigation slower #147

Open
ghost opened this issue Jun 3, 2016 · 4 comments
Open

Navigation slower #147

ghost opened this issue Jun 3, 2016 · 4 comments

Comments

@ghost
Copy link

ghost commented Jun 3, 2016

I noticed while navigating around that it seems slower than before. So, I pulled down a branch before the sidebar service and new theme. Indeed the navigation was noticeably faster than the latest branch. I have not deduced the exact cause.

@ghost
Copy link
Author

ghost commented Jun 3, 2016

I removed the sidebar and the navigation was still a bit slower than previously.

@tdonohue
Copy link
Member

tdonohue commented Jun 4, 2016

I noticed this as well, but wasn't able to narrow it down. If it isn't sidebar related could it be the new theme? I noticed the initial load is also a bit slower.

@ghost
Copy link
Author

ghost commented Jun 4, 2016

I simply removed the sidebar component. The sidebar service was still running and being injected. The slow down occurs when an attempt to navigate to a new route. When you click on a router link it pauses briefly before navigating. Before it navigated immediately and then performed asynchronous requests. If requests were cached the pages loaded immediately. I assume it is the sidebar service as it has ramifications on route changes. If it is not that, it could be due to the growing number of services being injected. Granular dependency injection may provide some performance improvements. Also, barreling will help.

@ghost
Copy link
Author

ghost commented Jun 4, 2016

It is unlikely to be the new theme. But you never know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant