Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enchantment effect stays when items are replaced in inventory #397

Closed
OxBrutal opened this issue Aug 18, 2022 · 1 comment · May be fixed by #419
Closed

Enchantment effect stays when items are replaced in inventory #397

OxBrutal opened this issue Aug 18, 2022 · 1 comment · May be fixed by #419
Assignees
@DaPigGuy
Labels
Resolution: Fixed Type: Bug

Comments

@OxBrutal
Copy link

OS and Versions

  • PocketMine-MP: 4.7.2
  • PiggyCustomEnchants: Latest Poggit
  • PHP: 8.0.19
  • Server OS: Linux

Issue:

VID-20220818-WA0122.mp4
  • When opening Inventory and moving the enchanted pickaxe Go to regular pickaxe, Then close the Inventory..they get the same enchant as the costume enchant
@OxBrutal
Copy link
Author

Bro?

@Aericio Aericio changed the title Bug Enchant Enchantment effect stays when items are replaced in inventory Jul 16, 2023
@Aericio Aericio mentioned this issue Jul 16, 2023
Closed
Aericio added a commit that referenced this issue Sep 29, 2023
@Aericio
Fix effects staying when items replaced in inventory, closes #397
d2fdb06
@Aericio Aericio linked a pull request Sep 29, 2023 that will close this issue
PM5 Update #419
Draft
@Aericio Aericio closed this as completed Sep 29, 2023
@Aericio Aericio mentioned this issue Sep 29, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaPigGuy DaPigGuy

Labels
Resolution: Fixed Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PM5 Update DaPigGuy/PiggyCustomEnchants
3 participants
@DaPigGuy @Aericio @OxBrutal