Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material system: can see through walls on plat23 #1249

Open
slipher opened this issue Aug 19, 2024 · 2 comments · May be fixed by #1299
Open

Material system: can see through walls on plat23 #1249

slipher opened this issue Aug 19, 2024 · 2 comments · May be fixed by #1299
Labels
A-Renderer T-Bug

Comments

@slipher
Copy link
Member

slipher commented Aug 19, 2024

On plat23 there is an unphysical situation, where some rooms are supposed to be covered by the skybox.
unvanquished_2024-08-18_221135_000
@slipher
Copy link
Member Author

slipher commented Sep 13, 2024

Apparently it just depends on PVS not to draw this. Setting r_novis you can see it without using the material system. Maybe this should be considered a map bug

@VReaperV
Copy link
Contributor

Apparently it just depends on PVS not to draw this. Setting r_novis you can see it without using the material system. Maybe this should be considered a map bug

I don't think it's a map bug so much as just how BSP works. I assume sky brushes are just treated the same as solid surfaces for the purposes of BSP.

I have a fix for this issue in mind, should be pretty simple.

@VReaperV VReaperV linked a pull request Sep 13, 2024 that will close this issue
Draft
@illwieckz illwieckz mentioned this issue Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Renderer T-Bug
Projects
Material system
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate skybrush material VReaperV/Daemon
2 participants
@slipher @VReaperV