From 459019543e648cba071a861e94b7983225a835dd Mon Sep 17 00:00:00 2001
From: Daniel Hunte <danielhunte@meta.com>
Date: Wed, 4 Dec 2024 14:44:11 -0800
Subject: [PATCH] fix(fuzzer): Fix toSql methods for NestedLoopJoinNode in
 Reference Query Runners (#11576)

Summary:

The select clause is completely missing in the produced query string.

Reviewed By: kagamiori

Differential Revision: D66132514
---
 velox/exec/fuzzer/DuckQueryRunner.cpp   | 3 +++
 velox/exec/fuzzer/PrestoQueryRunner.cpp | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/velox/exec/fuzzer/DuckQueryRunner.cpp b/velox/exec/fuzzer/DuckQueryRunner.cpp
index 6fdf10613bb69..6b7ac7d972a96 100644
--- a/velox/exec/fuzzer/DuckQueryRunner.cpp
+++ b/velox/exec/fuzzer/DuckQueryRunner.cpp
@@ -448,8 +448,11 @@ std::optional<std::string> DuckQueryRunner::toSql(
 
 std::optional<std::string> DuckQueryRunner::toSql(
     const std::shared_ptr<const core::NestedLoopJoinNode>& joinNode) {
+  const auto& outputNames = joinNode->outputType()->names();
   std::stringstream sql;
 
+  sql << "SELECT " << folly::join(", ", outputNames);
+
   // Nested loop join without filter.
   VELOX_CHECK(
       joinNode->joinCondition() == nullptr,
diff --git a/velox/exec/fuzzer/PrestoQueryRunner.cpp b/velox/exec/fuzzer/PrestoQueryRunner.cpp
index 6c69400525b85..12772bdc3a74c 100644
--- a/velox/exec/fuzzer/PrestoQueryRunner.cpp
+++ b/velox/exec/fuzzer/PrestoQueryRunner.cpp
@@ -662,8 +662,11 @@ std::optional<std::string> PrestoQueryRunner::toSql(
 
 std::optional<std::string> PrestoQueryRunner::toSql(
     const std::shared_ptr<const core::NestedLoopJoinNode>& joinNode) {
+  const auto& outputNames = joinNode->outputType()->names();
   std::stringstream sql;
 
+  sql << "SELECT " << folly::join(", ", outputNames);
+
   // Nested loop join without filter.
   VELOX_CHECK(
       joinNode->joinCondition() == nullptr,