Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving SVGs to PDFs by default #89

Open
ankur92 opened this issue Sep 5, 2024 · 2 comments
Open

Saving SVGs to PDFs by default #89

ankur92 opened this issue Sep 5, 2024 · 2 comments

Comments

@ankur92
Copy link

ankur92 commented Sep 5, 2024

Hi Dan!

Very resourceful repo!

Is there a particular reason to not store the SVGs as PDFs by default? It's an added step to install inkscape (not a big deal) but just curious.

@DanielSank
Copy link
Owner

We need to maintain a single source of truth for images. If the image is drawn as an SVG (with Inkscape or otherwise) that that's the source of truth. I do not want to store derived files e.g. PDF's because that runs the risk of committing un-synchronized copies of the SVG and associated PDF.

I agree that we're introducing a build-time dependency but there are several (free) programs that can convert image types and it's typically a single line command so I see it as a reasonable price to pay for avoiding synchronization errors.

@ankur92
Copy link
Author

ankur92 commented Sep 5, 2024

Thanks for the clarification! Makes sense for the sync issues. I was having trouble executing inkscape command on M1 processor but got it working now. One needs to provide the entire path 'Applications/Inkscape.app/Contents/MacOS/inkscape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants