Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update command timeout (and all time-based parameters) to TimeSpan #1744

Open
casperOne opened this issue Jan 5, 2022 · 0 comments
Open

Comments

@casperOne
Copy link

I suspect this should be grouped under #688 since this is a breaking change.

I've always hated how commandTimeout was typed as an int; .NET has always had an abstraction for time in the TimeSpan structure.

Exposing commandTimeout as a TimeSpan from Dapper would prevent the need for creating convenience wrappers and make readability/usability much better IMO.

Anecdotally, I have to look up the syntax every time I need to use commandTimeout as I can't remember if it's seconds or milliseconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant