Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding background music #20

Open
Ertain opened this issue Dec 30, 2018 · 3 comments
Open

Adding background music #20

Ertain opened this issue Dec 30, 2018 · 3 comments

Comments

@Ertain
Copy link

Ertain commented Dec 30, 2018

I have added background music. Try out my fork and see what you think.
@Dariasteam
Copy link
Owner

Well, I was skeptical about adding this (refused to make my own music when I was conceiving this) but I must admit it adds a nice touch. The licenses I saw in your repo also match the requirements, so I think is a yes.

Could you wait until the about / config page is created to do the pull request so both mute music / sound buttons exist?

Thank you!

@Ertain
Copy link
Author

Ertain commented Jan 2, 2019

Yeah I can do that.

@Ertain Ertain mentioned this issue Mar 13, 2019
Closed
@Ertain
Copy link
Author

Ertain commented Mar 14, 2019 •
edited
Loading

I have a music branch on my fork ready for testing. Just download that, run it, and tell me what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ertain @Dariasteam