Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add compression worker fallback mechanism #3126

Closed
wants to merge 3 commits into from

Conversation

thomas-lebeau
Copy link
Collaborator

Motivation

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/default-compression branch 2 times, most recently from 82c14aa to 9034634 Compare November 13, 2024 07:16
Copy link

cit-pr-commenter bot commented Nov 13, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.01 KiB 161.75 KiB 755 B +0.46%
Logs 55.75 KiB 55.80 KiB 52 B +0.09%
Rum Slim 109.59 KiB 110.03 KiB 451 B +0.40%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 0.000
addaction 0.051 0.044 -0.007
addtiming 0.001 0.001 -0.000
adderror 0.059 0.048 -0.011
startstopsessionreplayrecording 1.345 1.384 0.039
startview 1.409 1.228 -0.181
logmessage 0.030 0.029 -0.001
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 10.84 KiB 10.02 KiB -840 B
addaction 40.64 KiB 42.29 KiB 1.65 KiB
addtiming 8.64 KiB 8.25 KiB -407 B
adderror 46.08 KiB 46.62 KiB 550 B
startstopsessionreplayrecording 7.66 KiB 5.61 KiB -2095 B
startview 427.91 KiB 430.48 KiB 2.57 KiB
logmessage 41.20 KiB 42.88 KiB 1.68 KiB

🔗 RealWorld

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/default-compression branch 3 times, most recently from a79e131 to 5506507 Compare November 15, 2024 11:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.65%. Comparing base (fa08217) to head (bf94320).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
packages/rum-core/src/boot/rumPublicApi.ts 83.33% 1 Missing ⚠️
...kages/rum-core/src/domain/deflate/deflateWorker.ts 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3126      +/-   ##
==========================================
+ Coverage   93.64%   93.65%   +0.01%     
==========================================
  Files         276      276              
  Lines        7615     7631      +16     
  Branches     1708     1713       +5     
==========================================
+ Hits         7131     7147      +16     
  Misses        484      484              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/default-compression branch from 430d5a6 to 2f84284 Compare November 18, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants