Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 [RUM-6816] remove sendLogsAfterSessionExpiration #3183

Open
wants to merge 1 commit into
base: v6
Choose a base branch
from

Conversation

thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Nov 28, 2024

Motivation

Remove sendLogsAfterSessionExpiration option and makes sending logs after session expiration the default behavior

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.58%. Comparing base (89107f0) to head (01aa85d).
Report is 2 commits behind head on v6.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #3183      +/-   ##
==========================================
+ Coverage   93.56%   93.58%   +0.01%     
==========================================
  Files         279      279              
  Lines        7478     7477       -1     
  Branches     1689     1687       -2     
==========================================
  Hits         6997     6997              
+ Misses        481      480       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cit-pr-commenter bot commented Nov 28, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 151.96 KiB 151.96 KiB 0 B 0.00%
Logs 50.76 KiB 50.60 KiB -164 B -0.32%
Rum Slim 102.16 KiB 102.16 KiB 0 B 0.00%
Worker 25.16 KiB 25.16 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 0.000
addaction 0.042 0.040 -0.001
addtiming 0.001 0.001 -0.000
adderror 0.037 0.042 0.005
startstopsessionreplayrecording 0.895 0.870 -0.025
startview 1.337 1.196 -0.142
logmessage 0.020 0.022 0.001
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 8.88 KiB 9.40 KiB 529 B
addaction 41.79 KiB 39.49 KiB -2356 B
addtiming 8.35 KiB 7.46 KiB -915 B
adderror 44.47 KiB 45.61 KiB 1.14 KiB
startstopsessionreplayrecording 5.29 KiB 7.41 KiB 2.12 KiB
startview 406.69 KiB 404.67 KiB -2067 B
logmessage 41.53 KiB 41.72 KiB 202 B

🔗 RealWorld

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/remove-sendLogsAfterSessionExpiration branch from 46a7c51 to 079847a Compare November 28, 2024 15:32
@thomas-lebeau thomas-lebeau changed the title 💥 send logs after session expiration by default 💥 remove sendLogsAfterSessionExpiration Nov 28, 2024
Comment on lines -46 to -49
findTrackedSession: (_startTime, options) =>
(sessionIsActive && sessionIsTracked) || options?.returnInactive
? { id: sessionIsTracked ? SESSION_ID : undefined }
: undefined,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not correct. According to the implementation, if a session is not tracked, it should return undefined regardless of returnInactive option

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/remove-sendLogsAfterSessionExpiration branch from 079847a to 01aa85d Compare November 28, 2024 15:45
@thomas-lebeau thomas-lebeau changed the title 💥 remove sendLogsAfterSessionExpiration 💥 [RUM-6816] remove sendLogsAfterSessionExpiration Nov 28, 2024
@thomas-lebeau thomas-lebeau marked this pull request as ready for review November 28, 2024 15:57
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner November 28, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants