-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💥 [RUM-6816] remove sendLogsAfterSessionExpiration #3183
base: v6
Are you sure you want to change the base?
💥 [RUM-6816] remove sendLogsAfterSessionExpiration #3183
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v6 #3183 +/- ##
==========================================
+ Coverage 93.56% 93.58% +0.01%
==========================================
Files 279 279
Lines 7478 7477 -1
Branches 1689 1687 -2
==========================================
Hits 6997 6997
+ Misses 481 480 -1 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
46a7c51
to
079847a
Compare
findTrackedSession: (_startTime, options) => | ||
(sessionIsActive && sessionIsTracked) || options?.returnInactive | ||
? { id: sessionIsTracked ? SESSION_ID : undefined } | ||
: undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not correct. According to the implementation, if a session is not tracked, it should return undefined
regardless of returnInactive
option
079847a
to
01aa85d
Compare
Motivation
Remove
sendLogsAfterSessionExpiration
option and makes sending logs after session expiration the default behaviorChanges
Testing
I have gone over the contributing documentation.