From 97e21b68ef14225946b43f673e3a9ef5ad42e7fa Mon Sep 17 00:00:00 2001 From: Florent Clarret Date: Fri, 3 Jan 2025 12:36:03 +0000 Subject: [PATCH] Rename the freeze-date to cutoff-date in the create-schedule task (#32636) --- .github/workflows/create_release_schedule.yml | 8 ++++---- tasks/release.py | 7 +++---- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/workflows/create_release_schedule.yml b/.github/workflows/create_release_schedule.yml index 598dde6c22c10b..236e57f6acb6ad 100644 --- a/.github/workflows/create_release_schedule.yml +++ b/.github/workflows/create_release_schedule.yml @@ -7,8 +7,8 @@ on: description: 'Full version of the release to schedule (e.g. 7.31.0)' required: true type: string - freeze_date: - description: 'Isoformat date when we freeze CI (e.g. 2023-12-31)' + cutoff_date: + description: 'Isoformat date when we the cut-off happens (e.g. 2023-12-31)' required: true type: string @@ -38,6 +38,6 @@ jobs: ATLASSIAN_USERNAME : ${{ secrets.ATLASSIAN_USERNAME }} ATLASSIAN_PASSWORD : ${{ secrets.ATLASSIAN_PASSWORD }} INPUT_VERSION: ${{ github.event.inputs.version }} - FREEZE_DATE: ${{ github.event.inputs.freeze_date }} + CUTOFF_DATE: ${{ github.event.inputs.cutoff_date }} run: | - inv -e release.create-schedule --version "$INPUT_VERSION" --freeze-date "$FREEZE_DATE" + inv -e release.create-schedule --version "$INPUT_VERSION" --cutoff-date "CUTOFF_DATE" diff --git a/tasks/release.py b/tasks/release.py index c692d5c5a4ffe4..53bc3286ddf6f9 100644 --- a/tasks/release.py +++ b/tasks/release.py @@ -1029,19 +1029,18 @@ def generate_release_metrics(ctx, milestone, freeze_date, release_date): print(code_stats) -# TODO rename to freeze_date to cutoff_date @task -def create_schedule(_, version, freeze_date): +def create_schedule(_, version, cutoff_date): """Create confluence pages for the release schedule. Args: - freeze_date: Date when the code cut-off happened. Expected format YYYY-MM-DD, like '2022-02-01' + cutoff_date: Date when the code cut-off happened. Expected format YYYY-MM-DD, like '2022-02-01' """ required_environment_variables = ["ATLASSIAN_USERNAME", "ATLASSIAN_PASSWORD"] if not all(key in os.environ for key in required_environment_variables): raise Exit(f"You must set {required_environment_variables} environment variables to use this task.", code=1) - release_page = create_release_page(version, date.fromisoformat(freeze_date)) + release_page = create_release_page(version, date.fromisoformat(cutoff_date)) print(f"Release schedule pages {release_page['url']} {color_message('successfully created', 'green')}")