From 01b70b402d36cfc12a2b9cce7176541978b85948 Mon Sep 17 00:00:00 2001 From: levan-m <116471169+levan-m@users.noreply.github.com> Date: Fri, 9 Aug 2024 15:42:24 -0400 Subject: [PATCH] Use `unknown` tool version when env var is not set (#1345) (#1348) --- controllers/datadogagent/feature/enabledefault/feature.go | 2 +- .../datadogagent/feature/enabledefault/feature_test.go | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/controllers/datadogagent/feature/enabledefault/feature.go b/controllers/datadogagent/feature/enabledefault/feature.go index 1578e2e43..c742eac7c 100644 --- a/controllers/datadogagent/feature/enabledefault/feature.go +++ b/controllers/datadogagent/feature/enabledefault/feature.go @@ -477,7 +477,7 @@ func buildInstallInfoConfigMap(dda metav1.Object) *corev1.ConfigMap { } func getInstallInfoValue() string { - toolVersion := "datadog-operator" + toolVersion := "unknown" if envVar := os.Getenv(apicommon.InstallInfoToolVersion); envVar != "" { toolVersion = envVar } diff --git a/controllers/datadogagent/feature/enabledefault/feature_test.go b/controllers/datadogagent/feature/enabledefault/feature_test.go index e7b2d5549..96ff97623 100644 --- a/controllers/datadogagent/feature/enabledefault/feature_test.go +++ b/controllers/datadogagent/feature/enabledefault/feature_test.go @@ -7,9 +7,10 @@ package enabledefault import ( "encoding/json" - "github.com/google/go-cmp/cmp" "testing" + "github.com/google/go-cmp/cmp" + "github.com/stretchr/testify/assert" "gopkg.in/yaml.v2" corev1 "k8s.io/api/core/v1" @@ -41,7 +42,7 @@ func Test_getInstallInfoValue(t *testing.T) { { name: "Env var empty/unset (os.Getenv returns unset env var as empty string)", toolVersionEnvVarValue: "", - expectedToolVersion: "datadog-operator", + expectedToolVersion: "unknown", }, { name: "Env var set",