Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining entities to OriginIDFromAttributes #332

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add remaining entities to OriginIDFromAttributes #332

wants to merge 4 commits into from

Conversation

liustanley
Copy link
Contributor

What does this PR do?

Adds remaining entities from entity list: https://github.com/DataDog/datadog-agent/tree/main/comp/core/tagger#entity-ids.

I'm not sure if we have proper mappings for container_image_metadata, ecs_task and host.

Motivation

@liustanley liustanley requested a review from dineshg13 May 17, 2024 19:13
@liustanley liustanley requested a review from a team as a code owner May 17, 2024 19:13
mx-psi
mx-psi reviewed May 20, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need container platform to review this. It looks sensible to me, but I don't know if the chosen attributes are the right one with the docs we have

pkg/otlp/attributes/attributes.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi left review comments

@dineshg13 dineshg13 dineshg13 approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liustanley @dineshg13 @mx-psi