Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for any differences in behavior between DDSketch implementation in Saluki and Datadog Agent. #160

Open
Tracked by #156
tobz opened this issue Aug 8, 2024 · 0 comments
Labels
area/core Core functionality, event model, etc. effort/intermediate Involves changes that can be worked on by non-experts but might require guidance. good first issue Good for newcomers type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo.

Comments

@tobz
Copy link
Member

tobz commented Aug 8, 2024

Context

Saluki currently uses an implementation of DDSketch based on that of the Datadog Agent (seen here, in a tangentially-related package).

While the implementation in Saluki comes from Vector, where a good amount of effort was spent trying to ensure parity with the Agent-based implementation, the logic and associated unit tests have not been re-evaluated in a long time.

We should reaffirm that Saluki's implementation is correct by double-checking what we have -- the implementation itself, the unit tests we have, etc -- with that of the Datadog Agent implementation.

@tobz tobz added good first issue Good for newcomers area/core Core functionality, event model, etc. effort/intermediate Involves changes that can be worked on by non-experts but might require guidance. type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo. labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Core functionality, event model, etc. effort/intermediate Involves changes that can be worked on by non-experts but might require guidance. good first issue Good for newcomers type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo.
Projects
None yet
Development

No branches or pull requests

1 participant