Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DogStatsD source has full support for Origin Detection. #189

Open
1 task
Tracked by #188
tobz opened this issue Aug 15, 2024 · 0 comments
Open
1 task
Tracked by #188

Ensure DogStatsD source has full support for Origin Detection. #189

tobz opened this issue Aug 15, 2024 · 0 comments
Labels
area/components Sources, transforms, and destinations. effort/simple Involves trivial changes that should be fine so long as the code compiles and tests pass. good first issue Good for newcomers source/dogstatsd DogStatsD source. type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo.

Comments

@tobz
Copy link
Member

tobz commented Aug 15, 2024

Context

The DogStatsD source must have full support for Origin Detection, which includes:

  • container ID extension (e.g., counter:1|c|c:acdea168264a08f9aaca0dfc82ff3551418dfd22d02b713142a6843caa2f61bf for resolved container IDs, or counter:1|c|c:in-1273114 for container cgroup controller inode)
  • entity ID tag (e.g., counter:1|c|#dd.internal.entity_id:7e87a71f-5f07-4d4f-8560-d7dbe666c66b)
  • UDS-based peer socket credentials (uses SO_PEERCRED to get the process ID of the sending client, which is then resolved to the container ID it belongs to)
  • External Data extension (stringified list of additional origin attributes, e.g. counter:1|c|e:it-false,cn-nginx,pu-3413883c-ac60-44ab-96e0-9e52e4e173e2)

In scope

  • Collecting all possible sources of origin entity data and storing them on Metric

Out of scope

There's a number of very related items that are out of scope for this particular issue, but will be addressed separately as a follow-up.

  • Resolving non-container IDs to container IDs
  • Ensuring that enrichment behavior matches the Datadog Agent

Work items

(non-exhaustive, living list)

@tobz tobz added this to the ADP v0.2: Staging Ahoy milestone Aug 15, 2024
@tobz tobz added good first issue Good for newcomers area/components Sources, transforms, and destinations. type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo. effort/simple Involves trivial changes that should be fine so long as the code compiles and tests pass. source/dogstatsd DogStatsD source. labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/components Sources, transforms, and destinations. effort/simple Involves trivial changes that should be fine so long as the code compiles and tests pass. good first issue Good for newcomers source/dogstatsd DogStatsD source. type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo.
Projects
None yet
Development

No branches or pull requests

1 participant