-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[java] Report bugs info to JIRA (#3546)
- Loading branch information
1 parent
bffb2b1
commit ee5d104
Showing
11 changed files
with
17 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,7 +105,7 @@ def setup_blocking_before(self): | |
self.set_req1 = weblog.request("GET", path="/tag_value/clean_value_3876/200") | ||
self.block_req2 = weblog.request("OPTIONS", path="/tag_value/tainted_value_6512/200") | ||
|
||
@flaky(context.library < "[email protected]") | ||
@flaky(context.library < "[email protected]", reason="APMRP-360") | ||
def test_blocking_before(self): | ||
"""Test that blocked requests are blocked before being processed""" | ||
# first request should not block and must set the tag in span accordingly | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,9 +41,8 @@ def setup_main(self): | |
logger.debug(f"Sent 50 requests in {(datetime.datetime.now() - start_time).total_seconds()} s") | ||
|
||
@bug( | ||
context.library > "[email protected]" and context.library < "[email protected]", | ||
reason="_sampling_priority_v1 is missing", | ||
) | ||
context.library > "[email protected]" and context.library < "[email protected]", reason="APMRP-360" | ||
) # _sampling_priority_v1 is missing | ||
def test_main(self): | ||
"""send requests for 10 seconds, check that only 10-ish traces are sent, as rate limiter is set to 1/s""" | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,7 +77,7 @@ def test_custom_span_tags(self): | |
def setup_header_collection(self): | ||
self.r = weblog.get("/headers", headers={"User-Agent": "Arachni/v1", "Content-Type": "text/plain"}) | ||
|
||
@bug(context.library < f"python@{PYTHON_RELEASE_GA_1_1}", reason="a PR was not included in the release") | ||
@bug(context.library < f"python@{PYTHON_RELEASE_GA_1_1}", reason="APMRP-360") | ||
@bug(context.library < "[email protected]", weblog_variant="spring-boot-openliberty", reason="APPSEC-6734") | ||
@irrelevant(context.library not in ["golang", "nodejs", "java", "dotnet"], reason="test") | ||
def test_header_collection(self): | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,7 @@ def setup_blocking_test(self): | |
@bug( | ||
context.library >= "[email protected]" and context.library < "[email protected]", reason="APMRP-360", | ||
) | ||
@bug(library="java", reason="Request blocked but appsec.blocked tag not set") | ||
@bug(library="java", reason="APPSEC-56006") | ||
def test_blocking_test(self): | ||
"""Test with a denylisted user""" | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -925,9 +925,8 @@ def test_headers_precedence_propagationstyle_tracecontext_last_extract_first_fal | |
@missing_feature(context.library == "cpp", reason="DD_TRACE_PROPAGATION_EXTRACT_FIRST is not yet implemented") | ||
@missing_feature(context.library == "php", reason="DD_TRACE_PROPAGATION_EXTRACT_FIRST is not yet implemented") | ||
@bug( | ||
context.library < "[email protected]", | ||
reason="Legacy behaviour: tracecontext propagator would always take precedence", | ||
) | ||
context.library < "[email protected]", reason="APMRP-360" | ||
) # Legacy behaviour: tracecontext propagator would always take precedence | ||
def test_headers_precedence_propagationstyle_tracecontext_last_extract_first_true_correctly_propagates_tracestate( | ||
self, test_agent, test_library | ||
): | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ def setup_method_trace(self): | |
self.trace_request = weblog.trace("/waf", data=None) | ||
|
||
@irrelevant(library="php", reason="Trace method does not reach php-land") | ||
@bug(weblog_variant="spring-boot-payara", reason="This weblog variant is currently not accepting TRACE") | ||
@missing_feature(weblog_variant="spring-boot-payara", reason="This weblog variant is currently not accepting TRACE") | ||
def test_method_trace(self): | ||
interfaces.library.add_span_tag_validation(request=self.trace_request, tags={"http.method": "TRACE"}) | ||
|
||
|
@@ -270,9 +270,8 @@ def setup_client_ip(self): | |
self._setup_with_attack() | ||
|
||
@bug( | ||
context.library < "[email protected]", | ||
reason="X-Client-Ip not supported, see https://github.com/DataDog/dd-trace-java/pull/4878", | ||
) | ||
context.library < "[email protected]", reason="APMRP-360" | ||
) # X-Client-Ip not supported, see https://github.com/DataDog/dd-trace-java/pull/4878 | ||
def test_client_ip(self): | ||
"""Test http.client_ip is always reported in the default scenario which has ASM enabled""" | ||
meta = self._get_root_span_meta(self.request_with_attack) | ||
|
@@ -286,8 +285,8 @@ def setup_client_ip_vendor(self): | |
|
||
@bug(context.library < "[email protected]", reason="APMRP-360") | ||
@bug( | ||
context.library < "[email protected]", reason="not supported, see https://github.com/DataDog/dd-trace-java/pull/4878" | ||
) | ||
context.library < "[email protected]", reason="APMRP-360" | ||
) # not supported, see https://github.com/DataDog/dd-trace-java/pull/4878 | ||
def test_client_ip_vendor(self): | ||
"""Test http.client_ip is always reported in the default scenario which has ASM enabled when using vendor headers""" | ||
self._test_client_ip(self.FORWARD_HEADERS_VENDOR) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -238,7 +238,7 @@ def test_app_started_is_first_message(self): | |
), "app-started is not the first message by seq_id" | ||
|
||
@bug(weblog_variant="spring-boot-openliberty", reason="APPSEC-6583") | ||
@bug(weblog_variant="spring-boot-wildfly", reason="Jira missing") | ||
@bug(weblog_variant="spring-boot-wildfly", reason="APPSEC-6583") | ||
@bug(context.agent_version > "7.53.0", reason="Jira missing") | ||
def test_proxy_forwarding(self): | ||
"""Test that all telemetry requests sent by library are forwarded correctly by the agent""" | ||
|
@@ -369,7 +369,7 @@ def setup_app_dependencies_loaded(self): | |
@irrelevant(library="golang") | ||
@irrelevant(library="python") | ||
@missing_feature(context.library < "[email protected]", reason="Telemetry V2 is not implemented yet") | ||
@bug( | ||
@irrelevant( | ||
library="java", | ||
reason=""" | ||
A Java application can be redeployed to the same server for many times (for the same JVM process). | ||
|