Podman based local host #1240
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| package remote | ||
|
|
||
| import ( | ||
| "github.com/DataDog/test-infra-definitions/common" | ||
| "github.com/pulumi/pulumi/sdk/v3/go/pulumi" | ||
| ) | ||
|
|
||
| type connectionArgs struct { | ||
| host pulumi.StringInput | ||
| user string | ||
|
|
||
| // ==== Optional ==== | ||
| privateKeyPath string | ||
| privateKeyPassword string | ||
| sshAgentPath string | ||
| port int | ||
| } | ||
|
|
||
| type ConnectionOption = func(*connectionArgs) error | ||
|
|
||
| func buildConnectionArgs(host pulumi.StringInput, user string, options ...ConnectionOption) (*connectionArgs, error) { | ||
| args := &connectionArgs{ | ||
| host: host, | ||
| user: user, | ||
| port: 22, | ||
| } | ||
| return common.ApplyOption(args, options) | ||
| } | ||
|
|
||
| // WithPrivateKeyPath [optional] sets the path to the private key to use for the connection | ||
| func WithPrivateKeyPath(path string) ConnectionOption { | ||
| return func(args *connectionArgs) error { | ||
| args.privateKeyPath = path | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| // WithPrivateKeyPassword [optional] sets the password to use in case the private key is encrypted | ||
| func WithPrivateKeyPassword(password string) ConnectionOption { | ||
| return func(args *connectionArgs) error { | ||
| args.privateKeyPassword = password | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| // WithSSHAgentPath [optional] sets the path to the SSH Agent socket. Default to environment variable SSH_AUTH_SOCK if present. | ||
| func WithSSHAgentPath(path string) ConnectionOption { | ||
| return func(args *connectionArgs) error { | ||
| args.sshAgentPath = path | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| // WithPort [optional] sets the port to use for the connection. Default to 22. | ||
| func WithPort(port int) ConnectionOption { | ||
| return func(args *connectionArgs) error { | ||
| args.port = port | ||
| return nil | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| FROM ubuntu:20.04 | ||
|
|
||
| ENV DEBIAN_FRONTEND=noninteractive | ||
|
|
||
| RUN set -eu && \ | ||
| apt update; \ | ||
| apt install -y \ | ||
| --no-install-recommends \ | ||
| ca-certificates \ | ||
| curl \ | ||
| systemd \ | ||
| systemd-cron \ | ||
| sudo \ | ||
| openssh-server; | ||
|
|
||
| # setup ssh | ||
| RUN mkdir -p /etc/ssh/sshd_config.d && echo "PermitRootLogin without-password" > /etc/ssh/sshd_config.d/allow_root.conf | ||
| ARG DOCKER_HOST_SSH_PUBLIC_KEY | ||
| RUN mkdir -p /root/.ssh && echo $DOCKER_HOST_SSH_PUBLIC_KEY >> /root/.ssh/authorized_keys | ||
| RUN chmod 600 /root/.ssh/authorized_keys | ||
|
|
||
| RUN service ssh start | ||
|
|
||
| EXPOSE 22 | ||
|
There was a problem hiding this comment. 🟠 Code Vulnerabilitydo not expose ssh service from your container (...read more)Never expose admin ports such as the SSH port
|
||
|
|
||
| CMD ["/usr/sbin/init"] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will change the behavior because currently we always use port
80. We might end up with the config using port443when the fakeintake is deployed in ECS. Are we sure it still works as expected?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, testing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, this does not work with ecs. Good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually no,
agentparamsis used only on hostsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this made me realise that
inv aws.create-ecsdoes not work without LB, because we assumehttpsendpoints on ecs agent params https://github.com/DataDog/test-infra-definitions/blob/pducolin/docker-localhost/components/datadog/agent/ecs.go#L257There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the same time we don't support LB on hosts, because we always assume
httpprotocol. Creating a card to track thoseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://datadoghq.atlassian.net/browse/ADXT-769