Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling deleted users #85

Open
chalshaff12 opened this issue Aug 18, 2019 · 8 comments
Open

Handling deleted users #85

chalshaff12 opened this issue Aug 18, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@chalshaff12
Copy link

The app does not yet have the functionality implemented to delete a user.

However if/when this is implemented, how do we want to handle posts and comments by deleted users?

Those posts/comments can just disappear, or they can remain while showing the user as 'deleted' just like it does on Reddit.

Actually, IIRC on Reddit, the posts disappear but the comments remain with a 'deleted' user.

Also, what happens to that user's votes? Do they remain or get subtracted from the posts and comments?

@chalshaff12 chalshaff12 added the enhancement New feature or request label Aug 18, 2019
@mary060196
Copy link
Contributor

@chalshaff12 , thank you very much for raising this concern. It would probably be good to do what is easy for the database to handle. For example, if a user is deleted, both the posts and the comments would be deleted. The total number of votes should remain the same because they do not connect directly to that user, even when he or she is deleted.
I am not sure what the opinion of the product would be, so I assign Joe to this issue; he might give a clearer answer to this.
Thank you for your patience, @chalshaff12 !

@mary060196
Copy link
Contributor

@dirtydupe , in light of the question that @chalshaff12 asked, what should happen, potentially, when a user is deleted (or deletes his or her account)?
Thank you for your reply!

@dirtydupe
Copy link
Contributor

@chalshaff12 Good questions. You are remembering correctly. In my opinion it would be sufficient/simpler to remove the username and retain the votes. The comment/post could also remain so any conversations in the comments also stay.

@dirtydupe
Copy link
Contributor

@mary060196 We will have to give users that option eventually as well as the option to delete posts and individual comments. As I said above, I think that we should retain the content and votes of a user unless the user explicitly deletes a comment or post. In that case we remove content, comments and votes from the database all together.

@mary060196
Copy link
Contributor

@dirtydupe , got it: thanks! When this feature is added to the website, this is how content will be handled. I am not sure how much effort from now and on the guys from the Back End team will give for connecting such a feature to the server, so it is unclear when the feature will be added.

@chalshaff12
Copy link
Author

If the content is retained, will it still display the username? Or will it show that it is a deleted user?

@dirtydupe
Copy link
Contributor

I was thinking we handle it similarly to reddit, where [deleted] is displayed instead of the username.

@mary060196
Copy link
Contributor

That's a very good idea, @dirtydupe ! If you'd like, this is how the feature will be.
Thank you very much! Good luck on the final!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants