Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Naming standardization #1273

Draft
wants to merge 6 commits into
base: v3
Choose a base branch
from
Draft

refactor: Naming standardization #1273

wants to merge 6 commits into from

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Nov 11, 2024

done when

  • Rename GetIndex utility methods
  • Add [Obsolete] aliases for GetEma() to ToEma()
  • Add [Obsolete] aliases for Tuple variants
  • Other naming updates

@DaveSkender DaveSkender self-assigned this Nov 11, 2024
@DaveSkender DaveSkender changed the base branch from main to v3 November 11, 2024 23:34
Signed-off-by: Dave Skender <[email protected]>
@DaveSkender DaveSkender added this to the v3 milestone Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 13 changed files in this pull request and generated no suggestions.

Files not reviewed (7)
  • src/_common/Observables/StreamHub.cs: Evaluated as low risk
  • src/a-d/Alligator/Alligator.StreamHub.cs: Evaluated as low risk
  • src/m-r/Renko/Renko.StreamHub.cs: Evaluated as low risk
  • tests/indicators/_common/Observables/StreamHub.Utilities.Tests.cs: Evaluated as low risk
  • src/a-d/Adl/Adl.StreamHub.cs: Evaluated as low risk
  • src/a-d/AtrStop/AtrStop.StreamHub.cs: Evaluated as low risk
  • src/s-z/Sma/Sma.StreamHub.cs: Evaluated as low risk
Comments skipped due to low confidence (2)

src/a-d/Atr/Atr.StreamHub.cs:75

  • [nitpick] The variable name 'i' is ambiguous. It should be renamed to 'index'.
int i = indexHint ?? ProviderCache.IndexOf(item, true);

src/s-z/Tr/Tr.StreamHub.cs:54

  • [nitpick] The variable name 'i' is ambiguous. It should be renamed to 'index'.
int i = indexHint ?? ProviderCache.IndexOf(item, true);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 23 changed files in this pull request and generated no suggestions.

Files not reviewed (14)
  • src/Indicators.csproj: Language not supported
  • src/_common/Observables/StreamHub.cs: Evaluated as low risk
  • src/a-d/Alligator/Alligator.StreamHub.cs: Evaluated as low risk
  • tests/indicators/m-r/ParabolicSar/ParabolicSar.StaticSeries.Tests.cs: Evaluated as low risk
  • src/m-r/ParabolicSar/ParabolicSar.StaticSeries.cs: Evaluated as low risk
  • src/m-r/Renko/Renko.StreamHub.cs: Evaluated as low risk
  • tests/indicators/_common/Observables/StreamHub.Utilities.Tests.cs: Evaluated as low risk
  • src/_common/ObsoleteV3.cs: Evaluated as low risk
  • src/s-z/StdDevChannels/StdDevChannels.StaticSeries.cs: Evaluated as low risk
  • src/s-z/Sma/Sma.StreamHub.cs: Evaluated as low risk
  • src/a-d/Adl/Adl.StreamHub.cs: Evaluated as low risk
  • src/e-k/Ema/Ema.StreamHub.cs: Evaluated as low risk
  • src/a-d/AtrStop/AtrStop.StreamHub.cs: Evaluated as low risk
  • tests/indicators/e-k/Kvo/Kvo.StaticSeries.Tests.cs: Evaluated as low risk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant