-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Naming standardization #1273
base: v3
Are you sure you want to change the base?
Conversation
Signed-off-by: Dave Skender <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 13 changed files in this pull request and generated no suggestions.
Files not reviewed (7)
- src/_common/Observables/StreamHub.cs: Evaluated as low risk
- src/a-d/Alligator/Alligator.StreamHub.cs: Evaluated as low risk
- src/m-r/Renko/Renko.StreamHub.cs: Evaluated as low risk
- tests/indicators/_common/Observables/StreamHub.Utilities.Tests.cs: Evaluated as low risk
- src/a-d/Adl/Adl.StreamHub.cs: Evaluated as low risk
- src/a-d/AtrStop/AtrStop.StreamHub.cs: Evaluated as low risk
- src/s-z/Sma/Sma.StreamHub.cs: Evaluated as low risk
Comments skipped due to low confidence (2)
src/a-d/Atr/Atr.StreamHub.cs:75
- [nitpick] The variable name 'i' is ambiguous. It should be renamed to 'index'.
int i = indexHint ?? ProviderCache.IndexOf(item, true);
src/s-z/Tr/Tr.StreamHub.cs:54
- [nitpick] The variable name 'i' is ambiguous. It should be renamed to 'index'.
int i = indexHint ?? ProviderCache.IndexOf(item, true);
Signed-off-by: Dave Skender <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 23 changed files in this pull request and generated no suggestions.
Files not reviewed (14)
- src/Indicators.csproj: Language not supported
- src/_common/Observables/StreamHub.cs: Evaluated as low risk
- src/a-d/Alligator/Alligator.StreamHub.cs: Evaluated as low risk
- tests/indicators/m-r/ParabolicSar/ParabolicSar.StaticSeries.Tests.cs: Evaluated as low risk
- src/m-r/ParabolicSar/ParabolicSar.StaticSeries.cs: Evaluated as low risk
- src/m-r/Renko/Renko.StreamHub.cs: Evaluated as low risk
- tests/indicators/_common/Observables/StreamHub.Utilities.Tests.cs: Evaluated as low risk
- src/_common/ObsoleteV3.cs: Evaluated as low risk
- src/s-z/StdDevChannels/StdDevChannels.StaticSeries.cs: Evaluated as low risk
- src/s-z/Sma/Sma.StreamHub.cs: Evaluated as low risk
- src/a-d/Adl/Adl.StreamHub.cs: Evaluated as low risk
- src/e-k/Ema/Ema.StreamHub.cs: Evaluated as low risk
- src/a-d/AtrStop/AtrStop.StreamHub.cs: Evaluated as low risk
- tests/indicators/e-k/Kvo/Kvo.StaticSeries.Tests.cs: Evaluated as low risk
Signed-off-by: Dave Skender <[email protected]>
done when
GetIndex
utility methodsGetEma()
toToEma()