Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page top-margin issue because of recent header height change #29

Open
ardacebi opened this issue Mar 26, 2020 · 0 comments
Open

Page top-margin issue because of recent header height change #29

ardacebi opened this issue Mar 26, 2020 · 0 comments
Assignees
Labels
bug Something isn't working priority: high
Milestone

Comments

@ardacebi
Copy link
Contributor

Recently, the height of the header has been changed due to the addition of the school indicator below the Decury logo with #18.

Screen Shot 2020-03-26 at 21 15 57

This change added a bug that causes all pages to not have the necessary top margin.

Screen Shot 2020-03-26 at 21 17 30

As a solution to the issue, I've tried to add a top margin to the first element on the home screen, which is the classroom overview div:

.classroomdiv {
margin-top:110px;
}

Then I realized that this issue requires a fix for all pages and not just the home screen. I've removed my home screen fix with a commit and there's a need for a fix for all pages.

@ardacebi ardacebi added bug Something isn't working priority: high labels Mar 26, 2020
@ardacebi ardacebi added this to the 0.1.0-beta.1 milestone Mar 26, 2020
ardacebi added a commit that referenced this issue Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high
Projects
None yet
Development

No branches or pull requests

3 participants