Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ergebnis/composer-normalize #476

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

walbo
Copy link

@walbo walbo commented Dec 5, 2023

As discussed in techlead meeting 4.oct, remove the normalize package from project base.

@walbo walbo requested a review from a team December 5, 2023 20:48
@Clorith
Copy link
Member

Clorith commented Dec 5, 2023

For the sake of completeness, and the rationale behind it:

Although making composer.json follow a fixed set of rules, it adds unnecessary complexity to a setup, and as it is currently set up, it is a dev-dependency, meaning it will cause fatal errors during deployment flows, where --no-dev flags are passed.

If a dev wants to normalize the composer file of a project, they can of course run the command on their own, but maintaining Project Base as lean as possible makes sense, and leaves one less package to keep up to date :)

@Clorith Clorith merged commit ea7c1f3 into main Dec 5, 2023
2 checks passed
@Clorith Clorith deleted the remove-ergebnis-composer-normalize branch December 5, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants