Support Block Spacing API on custom containers #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stom bock margin v2
Composer package changes
|
stian-overasen
changed the title
olethomas
approved these changes
Jul 29, 2024
|
We'll keep this in Project Base for now and move it to T2 after testing it out in a project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When combining Block Spacing from WP with T2 Custom Block Margin v2 we limit the active containers to only the ones used by core (
.wp-site-blocks,.is-layout-constrained,.is-layout-flow). This works fine for most of the core blocks, including:Group,Column,Query,Post Content,Cover,DetailsandButtons.However, there are additional blocks where we might want to use the same block spacing (Media+Text, T2 Simple Media+Text, T2 Accordion, T2 Factbox, T2 Infobox, T2 FAQ Item). These blocks lack the
.is-layout-*class and therefore their child elements are not covered by the generated block spacing styles.This PR adds an override filter for these blocks and adds
is-layout-flowclass to the desired containers.This might not be the best approach, but it works for now. One alternative solution would be to add layout suppport to the T2 blocks, but we would still have to use the filter for Media+Text.