Allow missing optional column in core #1791
Labels
core
Issues related to the computational core in Julia
Comments
visr
added a commit
that referenced
this issue
Sep 3, 2024
#1792) Fixes #1771, the remaining part after #1788 was merged. I split out #1789 as a separate issue, though in this PR a lot of the preparatory work is already done (all changes related to TabulatedRatingCurve). This is breaking due to #1791 because of adding new optional columns. It is also breaking that TabulatedRatingCurve and Pump now only support one outflow edge. As far as I know this wasn't used anywhere though. We cannot easily support that anymore since we now look at downstream levels. Users should instead use separate Pumps or TabulatedRatingCurves, which can share the same upstream Basin, but go to different downstream nodes. I decided to start the reduction factors for reaching these limits from 2 centimeters away. There was one existing level based reduction factor, the level difference in the Outlet, which I also adjusted from 10 to 2 centimeter. I feel like 10 centimeter would be too much in areas where the level is controlled up to centimeter accuracies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Many tables have optional columns. This currently means that the column needs to be present, but is allowed to be filled with all missing values. It would be better if the core would also allow the column not to be present at all. This would allow us to add optional columns in a non-breaking manner.
Ribasim Python allows the missing column, and will always write it out filled with all missings. Therefore, reading and writing with Ribasim Python automatically migrates these changes.
The text was updated successfully, but these errors were encountered: