From 1cb7273eab7ac1e7da9b602e48ad0a78169ac0d3 Mon Sep 17 00:00:00 2001 From: 4naesthetic <37602498+4naesthetic@users.noreply.github.com> Date: Wed, 21 Aug 2024 11:27:02 +0100 Subject: [PATCH] Remove unnecessary component loop in analyzeNotificationCriteria Signed-off-by: 4naesthetic <37602498+4naesthetic@users.noreply.github.com> --- .../java/org/dependencytrack/util/NotificationUtil.java | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/main/java/org/dependencytrack/util/NotificationUtil.java b/src/main/java/org/dependencytrack/util/NotificationUtil.java index 7c8aef02e1..54eb0c8837 100644 --- a/src/main/java/org/dependencytrack/util/NotificationUtil.java +++ b/src/main/java/org/dependencytrack/util/NotificationUtil.java @@ -70,7 +70,6 @@ import java.util.HashMap; import java.util.HashSet; import java.util.List; -import java.util.ArrayList; import java.util.Map; import java.util.Optional; @@ -116,13 +115,9 @@ public static void analyzeNotificationCriteria(QueryManager qm, Vulnerability vu final Vulnerability completeVulnerability = qm.getVulnerabilityByVulnId(vulnerability.getSource(), vulnerability.getVulnId()); final List components = completeVulnerability.getComponents(); if (components != null && !components.isEmpty()) { - List detachedComponents = new ArrayList<>(); - for (final Component c : components) { - detachedComponents.add(qm.detach(Component.class, c.getId())); - } // To reduce noise we only emit a single notification for each updated vulnerability if it affects one // of our components. The component details are still useful for event consumers, so we pick the first one. - final Component detachedComponent = detachedComponents.getFirst(); + final Component detachedComponent = qm.detach(Component.class, components.get(0).getId()); final Vulnerability detachedVuln = qm.detach(Vulnerability.class, completeVulnerability.getId()); detachedVuln.setAliases(qm.detach(qm.getVulnerabilityAliases(completeVulnerability))); // Aliases are lost during detach above