Replies: 1 comment
-
So, I've been working on this for a bit and I now have some more questions...
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I was thinking about a solution for #2146 and am unsure of how to continue, so I figured I'd start a discussion to see how others think about this.
Currently, if a policy with multiple conditions is defined (either ANY or ALL operator doesn't really matter), all conditions are validated and violations are created. I already created a PR to only save the violations for ALL operator if they indeed all fail -- it however still creates multiple violations: 1 for each condition.
#2146 mentions this for the ALL operator, however thinking about this (and then testing it) made me realize the ANY operator actually does this as well. Personally I was expecting either operators to only show a single violation, but since nobody has reported this issue for the ANY operator, I would like some input from the community.
So, is the current implementation OK for the ANY operator, or should both operators be changed to only show a single violation -- probably with information which condition(s) are responsible for this violation?
Beta Was this translation helpful? Give feedback.
All reactions