Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RetroAchievements support #36

Closed
nfp0 opened this issue Feb 23, 2020 · 2 comments
Closed

Add RetroAchievements support #36

nfp0 opened this issue Feb 23, 2020 · 2 comments

Comments

@nfp0
Copy link

nfp0 commented Feb 23, 2020

Almost all bsnes and higan cores in Retroarch support RetroAchievements (even higan Accuracy and nSide Balanced, contrary to the info in the docs).

It would be great to have this excellent core also supporting RetroAchievements. Maybe code from the other bsnes/higan cores can be ported to this one to save time.

According to a contributor on the upstream repository, the missing implementation is this:

// Currently, there is no safe/sensible way to use the memory interface without severe hackery.
// Rely on higan to load and save SRAM until there is really compelling reason not to.
RETRO_API void *retro_get_memory_data(unsigned id)
{
return nullptr;
}
RETRO_API size_t retro_get_memory_size(unsigned id)
{
return 0;
}

Byuu says he won't do it himself but he'll be happy to accept a pull request if anyone implements this.
Is this a tall order, considering all previous higan/bsnes cores already implemented this?

I've also opened this issue here libretro/bsnes#27 on the libretro vanilla bsnes repository.

@DerKoun
Copy link
Owner

DerKoun commented Feb 24, 2020

I have to defer this to libretro. Memory is a part of the emulator I have no idea about. So I'll close this as out of scope, as it is not a video feature. Sorry.

@DerKoun DerKoun closed this as completed Feb 24, 2020
@nfp0
Copy link
Author

nfp0 commented Feb 25, 2020

Sure. It's understandable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants