-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various issues #180
Comments
Hi, magorium,
Best regards |
Hello yoyojacky, Thank you for the quick reply.
Yes, I did use the latest installation script as mentioned. That was the reason for me to address it :-) Using trunk (= main/master):
Nowhere does the readme state that a different branch needs to be checked out before running the script Therefor I assume that the above output is as intended. Thus I am sorry to have to disagree with your statement that the /tmp/ lines have been removed from the script. If you have a different branch where this situation is corrected then these corrections needs to be merged back to trunk (= main/master) or the name and checkout of the correct branch needs to be mentioned in the readme.
As can be seen the dtoverlay is present at the section named [cm5]
regards, |
Hi there: I can confirm that the current version of the script no longer uses figlet. However, deskpi-config does -- it throws an error if you run it without figlet installed. It still runs, but it won't display the fancy ASCII logo. I'm having similar issues getting the fan to work, though. I'm using a V2 DeskPi Pro, with a Pi 4 running a fresh installation of the latest version of RaspberryPiOS Bookworm. My config.txt includes As stated above, the install script attempts to copy the drivers and deskpi-config from From what I can tell, this is a leftover from an older version of the install script. It used to start by cloning the repo to But... even if I manually copy the drivers and deskpi-config to the correct location in Also, the front USB ports only sort of work -- they supply power (I can use them to power a USB light, or charge a phone), but the system doesn't recognize any devices I plug in -- devices that work fine when I plug them into the back USB ports. This is a minor issue -- I don't plan to use them for anything other than power. But maybe it helps shed some light on what's going wrong. I'm not a programmer, but here's my attempt at trying to debug this. When I try to run pwmFanControl64 manually, I get the following error:
When I try to run safeCutOffPower manually, it throws this error in a loop forever, filling up my terminal over and over again with:
So clearly something is wrong with the serial port interface. Sure enough, if I cd to Any idea what the problem is here, or how to fix it? I haven't changed anything from a fresh install of RaspberryPiOS other than setting my username, password and local via config.txt, running apt update and upgrade, and installing git to clone the repo. Thanks! |
@Meusique:
It is beginning to daunt me :-) Can you open up a terminal and issue the command:
And paste the complete output of that file for me/us ? @yoyojacky |
Here's my config.txt output:
|
I figured it out: in my config file, Seems like the fix here would be for the install script to explicitly check not only whether (That and fixing the other current issue of the script, where it attempts to copy files from Now I just need to figure out the noisy fan issue... (#25) |
Looks like you've got the same issue I had in your config.txt. Try doing what I did and see if it works for you. |
Thank you for the suggestion @Meusique. I already figured that out when I wrote my previous reply (hence why I asked to post your config in order to see if you had the same issue) The technical term for that is named conditional filtering and the documentation can be found here. I fixed mine by adding a pi4 section and adding the overlay line manually. Sorry for the late(r) reply but shortly after I got things to work I got haunted by the undervolted notifications again and shortly after that the power supply started making a hissing high pitched noise (changing its pitch higher and higher as time went on) and when I hasted myself to get it unplugged the power supply shorted out. So, I have to assume that my power supply that came with the Deskpi Pro V2 has been faulty from the start especially since using an official raspberry pi power adapter did not result in the same symptoms. You are correct that the (current) install script does not seem to properly recognizes the conditional filtering and there for makes the wrong assumption(s). I am sorry to say that I can't really help with the noisy fan. Mine does hum a little at lower revolutions but at 100% the hum is nearly gone and the fan sounds like a normal fan. I can only suggest to make sure that the fan area is clear from any obstructions and try to see if the fan or fan blades touches anything. tbh, I do not even know if it is possible to remove the fan from the ice-cooler (in order to bend some blades and/or the fan or be able to replace it). As it stands now and afaik at this point, there are 3 issues left:
Regarding 3, I am aware that the bookwork branch fixed that but the use of that branch not advertised anywhere. |
oh, magorium, that's my bad, seems like the brench is a little bit mess due to my mistake. I will double check it again an fix the bug. |
Oh, I forget to remove the figlet on |
please move this parameter to : [all]
dtoverlay=dwc2,dr_mode=host and do remember reboot your raspberry pi to take effect. |
install-raspios-64bit.sh seems to be partially fixed, but install-ubuntu-64.sh has still the same missing git clone to /tmp/deskpi code. # missing cp...
# copy pre-compiled binary file to /usr/bin/ folder
if [ -d /tmp/deskpi/ ]; then
cp -Rvf /tmp/deskpi/installation/drivers/c/pwmFanControl64 /usr/bin/pwmFanControl64
cp -Rvf /tmp/deskpi/installation/drivers/c/safeCutOffPower64 /usr/bin/safeCutOffPower64
cp -Rvf /tmp/deskpi/installation/deskpi-config /usr/bin/deskpi-config
chmod +x /usr/bin/pwmFanControl64
chmod +x /usr/bin/safeCutOffPower64
chmod +x /usr/bin/deskpi-config
fi install-raspios-64bit.sh and contain: # check if dwc2 dtoverlay has been enabled.
checkResult=`grep dwc2 /boot/firmware/config.txt`
if [ $? -ne 0 ]; then
....
the config.txt for bookworm contains... [cm5]
dtoverlay=dwc2,dr_mode=host
... the code above skips adding dtoverlay=dwc2,dr_mode=host to the [all] section which should be
maybe something like this could do the job? CONFIG_FILE="boot/firmware/config.txt"
SECTION="[all]"
LINE_TO_CHECK="dtoverlay=dwc2,dr_mode=host"
# Check if the [all] section exists in the file
if grep -q "\[all\]" "$CONFIG_FILE"; then
# Check if the LINE_TO_CHECK exists within the first 10 lines after [all] section
if grep -A 10 "\[all\]" "$CONFIG_FILE" | grep -q "$LINE_TO_CHECK"; then
echo "Line already exists in the [all] section."
else
echo "Adding line to the [all] section."
# Add the LINE_TO_CHECK below the [all] section
sed -i "/\[all\]/a$LINE_TO_CHECK" "$CONFIG_FILE"
fi
else
echo "Section [all] not found in the config file."
fi |
yes, it will be fixed at once~ |
Hi bro, |
hey yoyojack, |
Hi noanight, Well, when we tested, there were some differences in the environments of different systems. Now they require bookworm and bullseye to make pre-installed images. |
Thanks for your work on this, @yoyojacky! I would definitely second making sure that all versions of the install script check that I've switched to DietPi for now since it's a slicker fit for my use case than vanilla RaspberryPiOS, and the script works fine there because its default |
@yoyojacky: I have read your comments but unfortunately I could not understand the (which I assume are) Chinese parts. I have everything running since my previous last post so that isn't my issue (anymore). The issue I (currently) have is that the script itself is not working as advertised. I am personally in the position to rectify any mistakes but for ordinary users this might not be the case. As far as I am able to tell the only issue left now (because you seem to have addressed the other issues, many thanks for that) is that the dtoverlay entry is checked against the wrong filtering rule and therefor will not be added on/to systems that run/install Raspi OS bookworm. I'll leave my report open until that is fixed. In case you require help fixing the script to fix that issue then please let us know so that we are able to assist (I have solved it myself by adding a new pi4 filter section and adding the dtoverlay entry there but using the all filter section should work as well) |
dietPi? that's a cool distribution! yes, some of the distribution will not use /boot/firmware/config.txt to store config.txt file, |
Hi Bro, |
That is the tricky part. The answer to that question is yes for the standard bootconfig.txt that the raspberry provides with its bookworm distribution. The answer is no for those who (manually) tinkered with the bootconfig.txt and/or uses another distribution (I have seen examples from some people in the issues that show a completely different bootconfig.txt As already mentioned the filtering rules are explained here and the [all] filtering section is able to create a ambiguous situation for handling the bootconfig.txt. And that is not even mentioning the [non] filter. The current implementation of the script does not work. Not for Debian Bookworm at least and by seeing the issues mentioned for this repository also not for people using other distributions. Some of the opted solutions in this issue-thread are able to improve the situation (for Debian bookworm default bootconfig.txt) but also do not address all possible situations/combinations. I am even unable to solve the ambiguity in real code, let alone that a bash script is able to solve that. And all the above isn't a real issue, as long as it is mentioned in the readme on the front page of this repository and communicated to the end-user by the script during installation Manually adding and/or moving the overlay entry is less than 5 seconds of work for most people but not if you as an end-user do not have a clue whatsoever that you need to do that (or at least verify if the overlay entry is present at the correct filtering section).
No there actually isn't a trick. As explained above it needs to be added to the correct filtering section. That is why I personally opted to add the [pi4] filtering section and added the dtoverlay entry there (but that is purely my own personal preference). For "normal" Debian Bookworm users, adding the overlay to the [all] filtering section should be enough to make it work but, only for these people and those who did not manually tinkered with the bootconfig.txt contents. So, I state again: As long as the end-user is not informed about this situation and the script does not correctly add the dtoverlay parameter to the correct filtering section, I'll have to leave this issue open. See for example #186 to proof the point. regards |
In the boot process of the Raspberry Pi, the In the
Regarding the impact of placing the
Therefore, if your In summary, whether to place the regards |
Something with a brick wall :)
That indicates for every [all] filter that the configuration file contains and, which is per definition ambiquous (and yes, some distributions actually do that). And that is not even mentioning the fact that you can have several sections which are named similar. The official documentation does not mention what would or should happen in such cases (does it take the latest section as active one, does it collect all previous similar named sections, etc). Unless that is made clear by the Raspberry Pi developers it is impossible to solve this (let alone with a simple bash script). Please check some of the other reports that clearly show issues with this approach. Thus, as I propose for the umptieth time: mention it on the help/readme pages and be done with it instead of dragging this along and wasting both of our time. regards |
64-bit raspbian OS (or whatever they call it these days), deskpi pro V2
regards,
The text was updated successfully, but these errors were encountered: