-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: V2 mvp version with new components added #45
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://academy-turbo-git-feat-v2-mvp-developdao.vercel.app/ |
feat: migrated quiz component and related dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank for the big push here 🍻 i'm default approving while we're not yet in prod and working towards v2 mvp.
i don't have the typescript+nextjs expertise to give good feedback on the specifics of the implementation. just want to highlight that there are some styles not yet carried over from v1. for example:
- the callout component is unstyled:
- and the inline code (backticks) appears to create linebreaks
if it makes sense to clean up this type of thing in future PR(s), maybe alongside other styling polish, then cool by me 🚢
This is correct, and thank you for pointing it out. I will be fixing this styling difference and more in future PRs. Thank for reviewing @wolovim ! 🙌 If it is not too much to ask, I will highly appreciate if you can craete a list with CSS fixe needed to be done so we can track them. thanks again! |
feat: some small css fixes and enhancements
No description provided.