Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: V2 mvp version with new components added #45

Merged
merged 16 commits into from
Jan 4, 2024
Merged

Conversation

Markkos89
Copy link
Collaborator

No description provided.

@Markkos89 Markkos89 added enhancement New feature or request help wanted Extra attention is needed labels Dec 12, 2023
@Markkos89 Markkos89 self-assigned this Dec 12, 2023
Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 5:46pm
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 5:46pm

Copy link

github-actions bot commented Dec 12, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 33
🟢 Accessibility 96
🟠 Best practices 75
🟢 SEO 92
🟠 PWA 89

Lighthouse ran on https://academy-turbo-git-feat-v2-mvp-developdao.vercel.app/

@Markkos89 Markkos89 changed the title feat: importing new components following new approach feat: V2 mvp version with new components added Jan 3, 2024
@Markkos89 Markkos89 marked this pull request as ready for review January 3, 2024 04:21
Copy link
Contributor

@wolovim wolovim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank for the big push here 🍻 i'm default approving while we're not yet in prod and working towards v2 mvp.

i don't have the typescript+nextjs expertise to give good feedback on the specifics of the implementation. just want to highlight that there are some styles not yet carried over from v1. for example:

  • the callout component is unstyled:
Screenshot 2024-01-03 at 10 40 51 AM
  • and the inline code (backticks) appears to create linebreaks
Screenshot 2024-01-03 at 10 46 51 AM

if it makes sense to clean up this type of thing in future PR(s), maybe alongside other styling polish, then cool by me 🚢

@Markkos89
Copy link
Collaborator Author

thank for the big push here 🍻 i'm default approving while we're not yet in prod and working towards v2 mvp.

i don't have the typescript+nextjs expertise to give good feedback on the specifics of the implementation. just want to highlight that there are some styles not yet carried over from v1. for example:

  • the callout component is unstyled:
Screenshot 2024-01-03 at 10 40 51 AM * and the inline code (backticks) appears to create linebreaks Screenshot 2024-01-03 at 10 46 51 AM if it makes sense to clean up this type of thing in future PR(s), maybe alongside other styling polish, then cool by me 🚢

This is correct, and thank you for pointing it out.

I will be fixing this styling difference and more in future PRs.

Thank for reviewing @wolovim ! 🙌

If it is not too much to ask, I will highly appreciate if you can craete a list with CSS fixe needed to be done so we can track them.
As first thought, the .mdx styling is not being rendered and don't know why yet, but doubting about the /components/mdx/Components.tsx file - if you can take a look.

thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants