Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lessons 2, 3, 4, 5 with new Hardhat, ethers.js versions. And now OZ is using 0.8.20..... #213

Open
2 of 4 tasks
elPiablo opened this issue Jul 17, 2023 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed lesson content

Comments

@elPiablo
Copy link
Collaborator

elPiablo commented Jul 17, 2023

Hardhat and ethers.js get significant upgrades with breaking changes for our lessons

That means we need to either rerun the lessons to get the updated code output and update the lessons, or just manually update the code that will now break our present code e.g. .deployed() and .utils() have been changed or retired.

There is also a mention about Network helpers re-export. I'm not 100% sure what that means (without researching it more):
import helpers from "@nomicfoundation/hardhat-toolbox/network-helpers";

Check the link for all the details: https://github.com/NomicFoundation/hardhat/releases/tag/%40nomicfoundation%2Fhardhat-toolbox%403.0.0

  • fixed Build a Basic NFT lesson
  • fixed TierNFT lesson
  • checked need for changes and/or fixed Write Automated Test for Your Smart Contracts lesson
  • checked need for changes and/or fixed Connecting to a Front End lesson

Can we find out about these types of things: https://github.com/NomicFoundation/hardhat/releases/tag/%40nomicfoundation%2Fhardhat-toolbox%403.0.0 in a more predictable way? e.g. I came across a bug, and searched, and then had some luck and found this link. Could we get an alert from somewhere? e.g. to the repo, or is it an idea to have a Breaking changes channel in the DAO?

@elPiablo elPiablo added bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed lesson content labels Jul 17, 2023
@elPiablo
Copy link
Collaborator Author

Now OpenZeppelin have upgraded their contracts to solc 0.8.20, so any imported contracts from them into ours are going to break.
So we need to upgrade ours all to 0.8.20 as well......

@elPiablo elPiablo changed the title Update *Build a Basic NFT* and *TierNFT* lessons with new Hardhat, ethers.js versions Update *Build a Basic NFT* and *TierNFT* lessons with new Hardhat, ethers.js versions. And now OZ is using 0.8.20..... Nov 22, 2023
@elPiablo elPiablo changed the title Update *Build a Basic NFT* and *TierNFT* lessons with new Hardhat, ethers.js versions. And now OZ is using 0.8.20..... Update lessons 2, 3, 4, 5 with new Hardhat, ethers.js versions. And now OZ is using 0.8.20..... Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed lesson content
Projects
None yet
Development

No branches or pull requests

1 participant