Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: move to pytest+codecov #56

Open
Mayukhdeb opened this issue Apr 27, 2021 · 2 comments
Open

CI: move to pytest+codecov #56

Mayukhdeb opened this issue Apr 27, 2021 · 2 comments
Assignees

Comments

@Mayukhdeb
Copy link
Member

Currently devolearn uses a relatively simple testing suite i.e python3 setup.py test. But a much cleaner alternative would be to use pytest for testing and codecov for coverage reports.

Why use coverage reports ?
They help us see how much of the code is being tested after each push, this'll help us find the pieces of code that are important but remain untested.

Why pytest ?
From my own personal experience, python3 setup.py test crashes without an error message when the user tries to access a CUDA device (GPU) on the github actions runtime. This error would've been impossible to fix if I hadn't moved to using pytest (which showed me the proper error message).

@Mainakdeb
Copy link
Contributor

Hi @Mayukhdeb. Moving to Pytest seems like a good idea, apart from the CUDA related issue you mentioned, here are couple more reasons why we should move to Pytest

  • it allows to run a subset of the entire testing suite (useful when working on only one DevoLearn model)
  • it can run multiple tests in parallel (reducing execution time)
  • it detects test file and test functions automatically.

This seems like a good opportunity to learn how Pytest and Codecov work, feel free to assign this issue to me.

@Mayukhdeb
Copy link
Member Author

@Mainakdeb any updates on integrating codecov ?

s0mnaths added a commit to s0mnaths/devolearn that referenced this issue Sep 14, 2021
Mayukhdeb pushed a commit that referenced this issue Sep 16, 2021
* Set up Codecov (#56)
* Remove redundant tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants