turning off "citadel replied to so-and-so" logging doesn't seem to work

[GavJenks]

[GavJenks]

Citadel 3.11.4

[ProgrammerDan]

that's hostile_logging, though, no?

[GavJenks]

Sounds like command logging to me from the description:
"command_logging logs the response that Citadel sends to the player;"
"[INFO]: Citadel Sent so-and-so a reply ____"

But Ill try damage logging too

[ProgrammerDan]

The way it trends down in the screenshot -- that's someone breaking a chest, it's a hostile break log.

…

On Tue, Sep 10, 2019 at 1:13 PM GavJenks ***@***.***> wrote: Sounds like command logging to me from the description: "command_logging logs the response that Citadel sends to the player;" "[INFO]: Citadel Sent so-and-so a reply ____" But Ill try damage logging too — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#61?email_source=notifications&email_token=AADD5DWGBLPMM7Q67D2G56LQI7ISPA5CNFSM4IVBJIDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6L22XA#issuecomment-530034012>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADD5DXMAYPA7ZLX7JI726LQI7ISPANCNFSM4IVBJIDA> .

[GavJenks]

Okay so is command logging broken then? It's set to true and says it gives you replies sent back from citadel. But if what I'm seeing is hostile logging, then command logging isn't working when he seems to be getting /cti replies back those should be double logging right now yes?

[ProgrammerDan]

Yeah, no, you're right -- that's command logging. Been a long time since I looked at this code. Bad name for the config line I think, basically that hooks into the sendAndLog() function, and is of the format "Sent <player> reply <msg>". Confused me, b/c I forgot about block solidification being standard now :D. So, the issue is that setting command_logging: false doesn't do anything?

…

On Tue, Sep 10, 2019 at 1:31 PM GavJenks ***@***.***> wrote: Okay so is command logging broken then? It's set to true and says it gives you replies sent back from citadel. But if what I'm seeing is hostile logging, then command logging isn't working when he seems to be getting /cti replies back those should be double logging right now yes? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#61?email_source=notifications&email_token=AADD5DQ4UY6GNHEQ5ICJ4HLQI7KXFA5CNFSM4IVBJIDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6L4UCA#issuecomment-530041352>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADD5DXZMIOQOSOLG3YWJP3QI7KXFANCNFSM4IVBJIDA> .

[GavJenks]

I don't even know anymore, I'll retest both and get back to you

[ProgrammerDan]

Oy, sorry for the confusion -- thank you!

…

On Tue, Sep 10, 2019 at 2:11 PM GavJenks ***@***.***> wrote: I don't even know anymore, I'll retest both and get back to you — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#61?email_source=notifications&email_token=AADD5DT36KAXUNJDSY2YFADQI7PLJA5CNFSM4IVBJIDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6MAH2Q#issuecomment-530056170>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADD5DWMDGPHOPC2N6RNA2LQI7PLJANCNFSM4IVBJIDA> .